feat: Support urllib3 <= 2.1 for py 3.11#380
Merged
Merged
Conversation
This was referenced Oct 17, 2023
|
👍 ship it 🙏 🚀 |
duncanista
approved these changes
Oct 18, 2023
Contributor
duncanista
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
LGTM – just one question.
Could you be more specific on
I tested this on 3.11 and see it functions correctly, but importing boto3 in 3.10 and under fails.
I'm not sure I understand it correctly.
Contributor
Author
|
Sorry, I'll clarify and update: |
|
To confirm (for me please), The only material difference from my PR, makes this work with Python 3.10, or it is still broken if it selects boto3? Update, ignore, I see 3.11 now |
Contributor
Author
|
Yup, just 3.11 |
|
Works for me, it's the only one I'm using 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Followup to #329
Fixes #376
Motivation
Right now boto3 is at 1.26.90 for 3.7, 3.8, 3.9, and 3.10. This causes a known issue when users supply version >= 2.0 of urllib3.
Previously we pinned urllib3 to all versions of this library, but we'll open this up for Python 3.11.
Also, this marks urllib3 as optional as this library doesn't directly depend on it.
Testing Guidelines
I tested importing boto3 using urllib3==2.0.7 on python 3.10, it fails to import.
I tested the same function code w/ urllib3==2.0.7 on python 3.11 and the code runes fine.
This pin and the automated tests all pass, so we should be confident this change will open up py3.11 users to urllib3 2.0 without impacting other users using incompatible runtimes (3.7, 3.8, 3.9, and 3.10)
Additional Notes
Types of Changes
Check all that apply