feat: opt-in enablement of the instrumentation telemetry client#386
Merged
astuyve merged 3 commits intoNov 7, 2023
Merged
Conversation
astuyve
approved these changes
Nov 3, 2023
avara1986
reviewed
Nov 6, 2023
Co-authored-by: Alberto Vara <a.vara.1986@gmail.com>
Contributor
Author
|
FTR, I just did an e2e test which worked:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable the telemetry client when
DD_INSTRUMENTATION_TELEMETRY_ENABLED=trueMotivation
AppSec Open-Source Software Vulnerability Scanning (aka ASM OSS Vulns) works on top of telemetry data sent by the tracing libraries. We are launching our beta for AWS Lambda using this short-term solution, but the mid-term one is to leverage a side-scanning agent instead, not requiring instrumentation telemetry at all, and out of the lambdas and tracers.
Testing Guidelines
Additional Notes
Jira: APPSEC-11434
Types of Changes
Check all that apply