Improve error log message when no sns->sqs context found.#396
Merged
Conversation
astuyve
approved these changes
Nov 21, 2023
Contributor
astuyve
left a comment
There was a problem hiding this comment.
looks okay here, not sure how heavy throwing an exception is (kind of cpu intensive in node), but the logic is sound
7f3223b to
f4facef
Compare
f4facef to
dfef34f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of logging
log
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply