[SVLS-4422] Support for metrics with timestamps when the Extension is present#480
Merged
Conversation
purple4reina
approved these changes
Apr 26, 2024
duncanista
approved these changes
Apr 26, 2024
Contributor
duncanista
left a comment
There was a problem hiding this comment.
Amazing work Dylan – thanks for lazy loading and improving the code!
Could we add a screenshot to the PR showing a flamegraph with the overhead implications of this change for customers using the extension + timestamp metrics?
Contributor
Author
|
Dismissing reviews for now since I'm running into an issue with this this PR where all spans in a cold start have different trace IDs :( will tackle after the weekend |
purple4reina
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for metrics with timestamps (AKA historical metrics) when using the Extension. Dogstatsd does not support historical distribution metrics yet, so we must use the Datadog API client.
We were lazy loading the DD API module when the Extension was not present, so I've tried to be careful not to undo that work. Even with these changes, we should only initialize the API client once per Lambda environment if a timestamp parameter is detected when using
lambda_metric.Flame graph of imported modules on a cold start:
Motivation
#398
Testing Guidelines
Added a simple unit test + manual testing.
Additional Notes
Sister PR for NodeJS: DataDog/datadog-lambda-js#522
Types of Changes
Check all that apply