[SVLS-5265] S3 Event Handler Span Pointers#513
Merged
apiarian-datadog merged 9 commits intoSep 27, 2024
Conversation
alexgallotta
approved these changes
Sep 23, 2024
… rc" This reverts commit 6b083d4.
Contributor
Author
|
This PR somewhat surprisingly passes integration tests. The S3 lambda handler spans do in fact include span pointers, but they're not being serialized in dd-trace-py in the extension-less integration test environment. The extension does ship these span links correctly, though. We'll follow up with a patch on |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding Span Pointers for the upstream S3 objects when a lambda is triggered by an S3 ObjectCreated event.
Motivation
This is required to support auto-span-linking when S3 objects are used to chain lambda functions together.
Testing Guidelines
Added unit tests.
Types of Changes
Check all that apply