Enable compressed payloads on ThreadStats object#86
Conversation
|
Hi @csssuf, I'm closing the PR due to the lack of activity here. Feel free to reopen if this problem still persists and you would like to move forward. I also want to mention a new way (using the Lambda extension) to submit metrics directly from your Lambda functions (without using the forwarder) https://docs.datadoghq.com/serverless/datadog_lambda_library/extension/. |
|
Please reopen this issue, it has a lack of activity as the datadog maintainers didn't respond. @tianchu the PR is ready to merge. |
|
Thanks for the confirmation that this PR is still relevant! we will prioritize some testing before merging. Sorry for the long wait 🙇 |
38723f1 to
4fe6909
Compare
4fe6909 to
513172e
Compare
|
I could successfully reproduce the issue by submitting tons of data points within 10s, and enabling However, I do want to point out, although # inefficient
for i in range(1000000):
lambda_metric(
metric_name='my.metric',
value=i+1,
tags=['tag1:value1']
)
# efficient
sum = 0
for i in range(1000000):
sum = sum + i + 1
lambda_metric(
metric_name='my.metric',
value=sum,
tags=['tag1:value1']
) |
|
🎉 thanks!
Unfortunately, since we're submitting several distinct metrics with a large number of unique tag sets for each metric, aggregating that way wouldn't do anything for us - we do only submit a single value per unique |
What does this PR do?
Enable submitting compressed payloads to the Datadog API.
Motivation
We use lambdas to scrape metrics which we can't easily collect by other means. These metric lambdas can collect large numbers of metrics quickly, and occasionally submit too many metrics within the same flush interval for the Datadog API to handle. This is similar to the issue in DataDog/datadogpy#465. The solution implemented to fix that issue was compression of payloads submitted to the DD API.
Testing Guidelines
./scripts/run_tests.shAdditional Notes
n/a
Types of Changes
Check all that apply