feat: support ruby 3.4#118
Merged
Merged
Conversation
purple4reina
approved these changes
Apr 24, 2025
duncanista
commented
Apr 24, 2025
Comment on lines
+14
to
+19
| /opt/ruby/gems/3.2.0/gems/datadog-2.12.0/lib/datadog/core/logger.rb:14: info: Datadog::Core::Logger#initialize: does not call super probably | ||
| /opt/ruby/gems/3.2.0/gems/datadog-2.12.0/lib/datadog/core/logger.rb:14: info: Datadog::Core::Logger#initialize: does not call super probably | ||
| /opt/ruby/gems/3.2.0/gems/logger-1.7.0/lib/logger.rb:482: warning: Logger not initialized properly | ||
| /opt/ruby/gems/3.2.0/gems/logger-1.7.0/lib/logger.rb:482: warning: Logger not initialized properly | ||
| /opt/ruby/gems/3.2.0/gems/logger-1.7.0/lib/logger.rb:677: warning: Logger not initialized properly | ||
| /var/runtime/lib/runtime.rb:26: info: LoggerPatch#initialize: does not call super probably |
Contributor
Author
There was a problem hiding this comment.
This doesn't look right
Contributor
Author
There was a problem hiding this comment.
Looks like it might be related to aws/aws-lambda-ruby-runtime-interface-client#33 ?
duncanista
force-pushed
the
jordan.gonzalez/ruby-3.4-support
branch
from
4e185b6 to
3236ac5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for Ruby 3.4
Motivation
#117 – SVLS-6698
Testing Guidelines
Unit tests and integration tests
Additional Notes
N/A
Types of changes
Check all that apply