Skip to content

Remove 'simplejson' as a required dependency #265

@crccheck

Description

@crccheck

Hi. I just ran into the same problem outlined in this issue: psf/requests#3052

I've recently run into an issue where another library installed simple-json and because the requests library defaults to it if available, it caused all of our json requests to fail due to a decoding problem.

My opinionated summary of that thread is that in 2018, there's no reason to use simplejson anymore because:

  • If people cared about performance, they'd use ujson
  • Python versions that didn't have json in the standard lib have long fallen off support grids
  • simple is better than complex

Since datadog already has logic to fall back to the standard lib's json, it could simply remove simplejson from setup.py (probably for Python 2 too) and document that simplejson will be used if it's installed.

https://github.com/DataDog/datadogpy/blob/master/setup.py#L12

What do you think? Removing simplejson could simplify this project

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions