-
Notifications
You must be signed in to change notification settings - Fork 318
Closed
Description
Hi. I just ran into the same problem outlined in this issue: psf/requests#3052
I've recently run into an issue where another library installed simple-json and because the requests library defaults to it if available, it caused all of our json requests to fail due to a decoding problem.
My opinionated summary of that thread is that in 2018, there's no reason to use simplejson anymore because:
- If people cared about performance, they'd use ujson
- Python versions that didn't have
jsonin the standard lib have long fallen off support grids - simple is better than complex
Since datadog already has logic to fall back to the standard lib's json, it could simply remove simplejson from setup.py (probably for Python 2 too) and document that simplejson will be used if it's installed.
https://github.com/DataDog/datadogpy/blob/master/setup.py#L12
What do you think? Removing simplejson could simplify this project
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels