Set API Key in URL when submit distribution metrics#480
Merged
Conversation
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
The change looks good to me. This wasn't caught because we don't have integration tests for distributions. Would you mind adding some ? |
Contributor
Author
Contributor
Author
Makes sense. Let me look into it. |
74ff393 to
c0f08e9
Compare
c0f08e9 to
112868f
Compare
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nmuesch
approved these changes
Nov 15, 2019
Contributor
nmuesch
left a comment
There was a problem hiding this comment.
Thanks for fixing this and the initial test
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
* Set API Key in URL when submit distribution metrics * Add integration test for distribution metric submission
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api.Distribution.sendno longer works after #446, as endpointv1/distribution_pointsstill expects the api key in the URL parameter than header.To reproduce: