Add api for slack and Aws integrations#262
Closed
dipthegeezer wants to merge 2 commits intoDataDog:masterfrom
Closed
Add api for slack and Aws integrations#262dipthegeezer wants to merge 2 commits intoDataDog:masterfrom
dipthegeezer wants to merge 2 commits intoDataDog:masterfrom
Conversation
added 2 commits
April 17, 2018 13:35
Adds slack and aws integration using the existing sdks.
Signed-off-by: Dipesh Patel <dipesh@akoova.com>
|
@dipthegeezer Sorry for the delay on this one. We're adding support for all Cloud integrations in #429. Would you have a chance to just focus on Slack for this PR then? Thanks. |
|
Closing this for now as we could tackle Slack / Webhooks / PagerDuty in a single integration file perhaps and AWS (+ other Cloud integrations are being taken care of in #429) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the integrations or slack and aws based on the datadog api documentation. I would like to run the integration tests but not really sure how to do it. If someone can advise.