Merged
Conversation
gzussa
previously requested changes
Jan 25, 2019
nmuesch
reviewed
Jan 25, 2019
| except socket.error: | ||
| except (socket.error, socket.herror, socket.gaierror) as se: | ||
| log.info("Error submitting packet, dropping the packet and closing the socket") | ||
| self.close_socket() |
Contributor
There was a problem hiding this comment.
Should we be closing the socket in the second except clause as well?
Author
There was a problem hiding this comment.
Not sure, # If set, use socket directly, would the last exception cover the case of not using the socket and thus not needing to close it? Or am I on the wrong track there?
ofek
requested changes
Jan 28, 2019
Contributor
ofek
left a comment
ofek
left a comment
There was a problem hiding this comment.
This doesn't address the threading issue. You need to put a lock in get_socket.
dabcoder
force-pushed
the
davidb/handle-exceptions
branch
from
68cc551 to
86211db
Compare
gzussa
dismissed
their stale review
Looks good to me but I would like @ofek to confirm as well regarding the lock
ofek
requested changes
Feb 5, 2019
Co-Authored-By: dabcoder <david.bouchare@datadoghq.com>
ofek
approved these changes
Feb 5, 2019
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
* Handle all exceptions * Change log levels and increase max line for tests * Add lock to address threading issues * Remove conversion to str Co-Authored-By: dabcoder <david.bouchare@datadoghq.com>
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
* Handle all exceptions * Change log levels and increase max line for tests * Add lock to address threading issues * Remove conversion to str Co-Authored-By: dabcoder <david.bouchare@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix #212.