Conversation
nmuesch
approved these changes
May 29, 2019
Contributor
nmuesch
left a comment
nmuesch
left a comment
There was a problem hiding this comment.
Looks good to me. Approving but do you think its worthwhile to add a test on this here - https://github.com/DataDog/datadogpy/blob/master/tests/integration/api/test_api.py ?
nmuesch
reviewed
May 29, 2019
| (req_method, req_url), others = self.request_mock.call_args() | ||
| self.assertEquals(method, req_method, req_method) | ||
| self.assertEquals(url, req_url, req_url) | ||
| self.assertEqual(method, req_method, req_method) |
Contributor
There was a problem hiding this comment.
💜 on updating this to its non deprecated alias 😄
nmuesch
approved these changes
May 29, 2019
Contributor
nmuesch
left a comment
nmuesch
left a comment
There was a problem hiding this comment.
LGTM, thanks for the tests.
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
This was referenced Jun 19, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EU instance (api.datadoghq.eu) refuses GET requests with a body (even if empty JSON dict
{}) and responds with400 Bad Request.This PR simply set the body to
Nonewhen making GET requests.Fixes #375