Convert CaseInsensitiveDict response headers to dict#396
Closed
Tenzer wants to merge 1 commit intoDataDog:masterfrom
Tenzer:dict-response_headers
Closed
Convert CaseInsensitiveDict response headers to dict#396Tenzer wants to merge 1 commit intoDataDog:masterfrom Tenzer:dict-response_headers
Tenzer wants to merge 1 commit intoDataDog:masterfrom
Tenzer:dict-response_headers
Conversation
Requests by default makes the response headers into it's own custom type,
`CaseInsensitiveDict`, which can't be JSON serialized without extra work.
This affects the `dog timeboard show ...` and `dog screenboard show ...`
commands, as they JSON encode the Python data structures and they will give
the following error message without this change:
TypeError: Object of type CaseInsensitiveDict is not JSON serializable
This fixes it by explictly converting the response headers object to a dict
before being added to the response object.
Contributor
Author
|
Rebased on the latest master branch. |
Contributor
Author
|
I can see this PR is no longer necessary as the addition of the response headers to the response object was reverted again in dac5c40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests by default makes the response headers into it's own custom type,
CaseInsensitiveDict, which can't be JSON serialized without extra work.This affects the
dog timeboard show ...anddog screenboard show ...commands, as they JSON encode the Python data structures and they will give
the following error message without this change:
This fixes it by explictly converting the response headers object to a dict
before being added to the response object.