Merged
Conversation
zippolyte
requested changes
Aug 1, 2019
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
A couple of nits.
Also, let's create a test that specifically test the case where your host contains a slash at the end.
dabcoder
force-pushed
the
davidb/api-host-url
branch
from
fac60d9 to
3aa3750
Compare
nmuesch
reviewed
Aug 12, 2019
nmuesch
approved these changes
Aug 15, 2019
Contributor
nmuesch
left a comment
nmuesch
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
* Remove trailing whitespace from api_host * Attempt to fix url issue * Implement first review feedback * Better understanding of urljoin behavior * Do not use the API url in tests
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
* Remove trailing whitespace from api_host * Attempt to fix url issue * Implement first review feedback * Better understanding of urljoin behavior * Do not use the API url in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix #411.