Conversation
|
@yannmh Thanks - I think this covers the operator-set priority just fine. What I don't get with this is that there's still no method for a cron job failing to be the "right" priority. An example from our Chef handler where we detect whether it was pass/fail, and set priority accordingly. If I were to add dogwrap to any cron job (to emit events on completion), I'd want the successes to be quiet, and the failures to be visible. I'm happy to explain this further - but what's making you uncomfortable with auto-detecting priority? |
|
Thanks for your reply. I brought some extra changes in my PR. The reason for my concern is that this will change the event priorities of current jobs sumitting 'success' type events, without any more notice than the CHANGELOG: can that be considered as a backward incompatibility ? |
|
I don't think it's an issue. Merging. |
|
Thanks! |
Fix #18
I don' feel confortable about auto-selecting a priority based on the output (i.e.
SUCCESS->lowandERROR-> 'normal'.)cc @miketheman