Skip to content

[dogwrap] add priority option#42

Merged
yannmh merged 2 commits intomasterfrom
yann/dogwrap-priority-option
Apr 24, 2015
Merged

[dogwrap] add priority option#42
yannmh merged 2 commits intomasterfrom
yann/dogwrap-priority-option

Conversation

@yannmh
Copy link
Copy Markdown

@yannmh yannmh commented Apr 23, 2015

Fix #18

I don' feel confortable about auto-selecting a priority based on the output (i.e. SUCCESS -> low and ERROR -> 'normal'.)
cc @miketheman

@yannmh yannmh self-assigned this Apr 23, 2015
@miketheman
Copy link
Copy Markdown
Contributor

@yannmh Thanks - I think this covers the operator-set priority just fine.

What I don't get with this is that there's still no method for a cron job failing to be the "right" priority.

An example from our Chef handler where we detect whether it was pass/fail, and set priority accordingly.

If I were to add dogwrap to any cron job (to emit events on completion), I'd want the successes to be quiet, and the failures to be visible.

I'm happy to explain this further - but what's making you uncomfortable with auto-detecting priority?

@yannmh
Copy link
Copy Markdown
Author

yannmh commented Apr 24, 2015

Thanks for your reply.

I brought some extra changes in my PR.

The reason for my concern is that this will change the event priorities of current jobs sumitting 'success' type events, without any more notice than the CHANGELOG: can that be considered as a backward incompatibility ?

@yannmh
Copy link
Copy Markdown
Author

yannmh commented Apr 24, 2015

I don't think it's an issue. Merging.

yannmh pushed a commit that referenced this pull request Apr 24, 2015
@yannmh yannmh merged commit 809abc4 into master Apr 24, 2015
@miketheman
Copy link
Copy Markdown
Contributor

Thanks!

@yannmh yannmh deleted the yann/dogwrap-priority-option branch April 24, 2015 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dogwrap events should determine priority based on result

2 participants