Skip to content

Default sample rate#470

Merged
dabcoder merged 4 commits intoDataDog:masterfrom
dabcoder:davidb/default-sample-rate
Oct 29, 2019
Merged

Default sample rate#470
dabcoder merged 4 commits intoDataDog:masterfrom
dabcoder:davidb/default-sample-rate

Conversation

@dabcoder
Copy link
Copy Markdown

Picks up #231.

dtao and others added 4 commits October 10, 2017 15:16
The idea is quite similar to constant_tags: when initializing a
DogStatsd object, you can specify a value that should apply to *all*
metrics.

This change is backwards compatible. You can still pass in sample_rate
on a per-call basis and the value will override the default.
@dabcoder dabcoder requested a review from a team as a code owner October 29, 2019 10:03
Copy link
Copy Markdown
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabcoder
Copy link
Copy Markdown
Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dabcoder dabcoder merged commit 80c9603 into DataDog:master Oct 29, 2019
@dabcoder dabcoder deleted the davidb/default-sample-rate branch October 29, 2019 15:00
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Nov 28, 2019
* add support for default_sample_rate

The idea is quite similar to constant_tags: when initializing a
DogStatsd object, you can specify a value that should apply to *all*
metrics.

This change is backwards compatible. You can still pass in sample_rate
on a per-call basis and the value will override the default.

* Fix typo t.assert...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants