[dogstatsd] Handle OSError on socket.close on Python 3.6+#510
Merged
dabcoder merged 2 commits intoDataDog:masterfrom Jan 10, 2020
Merged
[dogstatsd] Handle OSError on socket.close on Python 3.6+#510dabcoder merged 2 commits intoDataDog:masterfrom
dabcoder merged 2 commits intoDataDog:masterfrom
Conversation
Since Python 3.6 it's possible for socket.close to raise an OSError EBADF when the socket's fd is already closed. https://bugs.python.org/issue29343
dabcoder
suggested changes
Jan 8, 2020
dabcoder
left a comment
dabcoder
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Left a note.
Co-Authored-By: David Bouchare <david.bouchare@datadoghq.com>
dabcoder
approved these changes
Jan 9, 2020
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jd
approved these changes
Jan 10, 2020
Contributor
Author
|
Thanks for the quick merge folks. |
zippolyte
added
the
changelog/Fixed
zippolyte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR handles unexpected exceptions in
DogStatsd.close_socket().Under certain obscure circumstances we get a crash on Python 3.6+ if the file descriptor vanishes before close is called.
See https://bugs.python.org/issue29343