Skip to content

Add enum for monitor types#544

Merged
zippolyte merged 2 commits intomasterfrom
hippo/mt
Mar 6, 2020
Merged

Add enum for monitor types#544
zippolyte merged 2 commits intomasterfrom
hippo/mt

Conversation

@zippolyte
Copy link
Copy Markdown
Contributor

@zippolyte zippolyte commented Mar 6, 2020

What does this PR do?

Closes #99 by adding a class MonitorType with constants for the allowed values

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@zippolyte zippolyte added the changelog/Added Added features results into a minor version bump label Mar 6, 2020
@zippolyte zippolyte requested a review from a team as a code owner March 6, 2020 09:41
@zippolyte zippolyte merged commit 0ac4103 into master Mar 6, 2020
@zippolyte zippolyte deleted the hippo/mt branch March 6, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gzussa gzussa gzussa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Monitor types as values

2 participants

@zippolyte @gzussa