Conversation
zippolyte
added
resource/threadstats
changelog/Added
jirikuncar
suggested changes
Mar 6, 2020
Contributor
jirikuncar
left a comment
jirikuncar
left a comment
There was a problem hiding this comment.
Nice! I have only style comments and probably one copy&paste typo.
Co-Authored-By: Jiri Kuncar <jiri.kuncar@datadoghq.com>
jirikuncar
approved these changes
Mar 6, 2020
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #131
Description of the Change
Add
Setclass andsetmethod to threadstats object to support set metrics in threadstatsVerification Process
unit tests
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.