Add support for DD_ENV, DD_SERVICE, and DD_VERSION environment variables#548
Merged
jirikuncar merged 2 commits intomasterfrom Mar 17, 2020
Merged
Conversation
jdgumz
added
the
changelog/Added
jirikuncar
reviewed
Mar 10, 2020
jdgumz
force-pushed
the
jesse.gumz/add-support-for-dd-env-service-version-tags
branch
from
3ba7ca8 to
14c724b
Compare
jirikuncar
reviewed
Mar 10, 2020
jirikuncar
reviewed
Mar 10, 2020
hush-hush
requested changes
Mar 10, 2020
Member
hush-hush
left a comment
hush-hush
left a comment
There was a problem hiding this comment.
The PR looks good, just a small nit about the docstring
jdgumz
changed the title
hush-hush
previously approved these changes
Mar 11, 2020
jirikuncar
reviewed
Mar 12, 2020
jirikuncar
reviewed
Mar 12, 2020
jirikuncar
previously approved these changes
Mar 12, 2020
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jdgumz
changed the title
jdgumz
force-pushed
the
jesse.gumz/add-support-for-dd-env-service-version-tags
branch
from
419e9c9 to
b7296e1
Compare
… for env, service, and version
jdgumz
force-pushed
the
jesse.gumz/add-support-for-dd-env-service-version-tags
branch
from
b7296e1 to
4054a10
Compare
hush-hush
previously requested changes
Mar 12, 2020
jirikuncar
dismissed
hush-hush’s stale review
We try to stay backward compatible.
jirikuncar
approved these changes
Mar 12, 2020
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hush-hush
approved these changes
Mar 12, 2020
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jirikuncar
deleted the
jesse.gumz/add-support-for-dd-env-service-version-tags
branch
therve
added a commit
that referenced
this pull request
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for
DD_ENV,DD_SERVICE, andDD_VERSIONto be used for setting{env, service, version}as global tags.Description of the Change
The statsd client will now also read from the environment variables above to set global tag configuration. The tags are limited to the set of
{env, service, version}.Alternate Designs
If there is a better way to set global tag configuration from environment variables, I'll gladly make the change. I largely drew upon the existing pattern I saw.
Possible Drawbacks
None that I can think of - the changes are additive in nature.
Verification Process
Unit tests.
Additional Notes
None.
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.