Skip to content

Add excluded_regions to POST/PUT AWS lib#552

Merged
sabiurr merged 5 commits intomasterfrom
excluded-regions-aws-api
Mar 23, 2020
Merged

Add excluded_regions to POST/PUT AWS lib#552
sabiurr merged 5 commits intomasterfrom
excluded-regions-aws-api

Conversation

@sabiurr
Copy link
Copy Markdown
Contributor

@sabiurr sabiurr commented Mar 20, 2020

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Adds excluded_regions field to AWS API client library for create/update. This will store excluded regions as part of AWS account data in integration config, which will be excluded by AWS crawlers from metric collection

https://datadoghq.atlassian.net/browse/AWS-344

Description of the Change

Updating docs to show excluded_regions

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sabiurr sabiurr requested a review from a team as a code owner March 20, 2020 17:12
@jirikuncar
Copy link
Copy Markdown
Contributor

I have updated the cassette using following steps:

  1. remove old cassette rm tests/integration/api/cassettes/TestAwsIntegration.test_update.yaml
  2. record pytest --vcr-record=all tests/integration/api/test_aws_integration.py -vvv -k test_update
  3. verify pytest --vcr-record=none tests/integration/api/test_aws_integration.py -vvv -k test_update

@jirikuncar
Copy link
Copy Markdown
Contributor

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jirikuncar jirikuncar added changelog/Added Added features results into a minor version bump resource/api labels Mar 21, 2020
@sabiurr sabiurr merged commit 6319ebd into master Mar 23, 2020
@sabiurr sabiurr deleted the excluded-regions-aws-api branch March 23, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump resource/api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants