Skip to content

[dogstatsd] Correct inverted constants#568

Merged
prognant merged 1 commit intomasterfrom
prognant/fix-dogstatsd-inverted-constants
Jun 19, 2020
Merged

[dogstatsd] Correct inverted constants#568
prognant merged 1 commit intomasterfrom
prognant/fix-dogstatsd-inverted-constants

Conversation

@prognant
Copy link
Copy Markdown
Contributor

What does this PR do?

Fix inversion while using constants in dogstatsd client.

Description of the Change

Alternate Designs

N/A

Possible Drawbacks

N/A

Verification Process

Issue was observed while capturing packet that were bigger than expected.

Additional Notes

N/A

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@prognant prognant requested a review from a team as a code owner June 19, 2020 14:05
Copy link
Copy Markdown
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️

@prognant prognant merged commit c160dcb into master Jun 19, 2020
@prognant prognant deleted the prognant/fix-dogstatsd-inverted-constants branch June 19, 2020 15:53
@prognant prognant added kind/bug Bug related issue changelog/Fixed Fixed features results into a bug fix version bump labels Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants