[Internal] Remove unused decorator dependency#651
Merged
therve merged 1 commit intoDataDog:masterfrom Apr 26, 2021
TheKevJames:nuke-decorator
Merged
[Internal] Remove unused decorator dependency#651therve merged 1 commit intoDataDog:masterfrom TheKevJames:nuke-decorator
therve merged 1 commit intoDataDog:masterfrom
TheKevJames:nuke-decorator
Conversation
Either this is unused and we can avoid it as unnecessary or it's somehow used by magic and I'm about to learn something.
Contributor
Author
|
The contributing instructions tell me to add a changelog label (probably |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
Thanks for your patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the unused dependency on decorator, which as far as I can tell is completely unused. It appears this library was introduced as a dependency in the first commit to this repo but never actually used directly.
This will help make installations faster and slimmer as well as reducing some maintenance (eg. see #646, where the datadogpy build was broken due to environment mismatches in this dependency).
Description of the Change
Removes the unused dependency from the
setup.pyfile. This will prevent it from being included at installation time ofdatadogpy.Alternate Designs
N/A
Possible Drawbacks
If the decorator library is being used in some non-standard way, this could remove something we're relying on (note: see "Verification Process" for why I don't think this is the case).
Verification Process
I verified this change through:
datadogpy: no instances of accessing thedecoratorlibrary were founddecoratorcodebase for anything "unusual" such as install-time side-effects or other such things we might be "magically" relying on: did not find anyAdditional Notes
N/A
Release Notes
N/A
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.