[dogstatsd] Fix unicode handling of event text#661
Merged
Conversation
sgnn7
added
changelog/Fixed
sgnn7
force-pushed
the
sgnn7/fix-dsd-unicode-processing
branch
2 times, most recently
from
419b924 to
b2bffb6
Compare
Old code was not properly handling unicode in messages which included incorrect length calculation in Python3 and error messages in Python2. We now properly evaluate those values before sending the data.
sgnn7
force-pushed
the
sgnn7/fix-dsd-unicode-processing
branch
from
b2bffb6 to
2dc9948
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
therve
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes handling of unicode data when sending events in dogstatsd
Description of the Change
We now properly handle both the type and length calculation of such strings
Closes #660
Alternate Designs
Possible Drawbacks
Tiny reduction in throughput
Verification Process
printto string composed inevent()python2 -m unittest -vvv tests.unit.dogstatsd.test_statsd.TestDogStatsd.test_unicode_eventpython3 -m unittest -vvv tests.unit.dogstatsd.test_statsd.TestDogStatsd.test_unicode_eventAdditional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.