Skip to content

Improved dogstatsd mypy integration by adding additional type annotations #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgnn7 merged 2 commits into from
Feb 2, 2022
Merged

Improved dogstatsd mypy integration by adding additional type annotations #710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d0c22b
Extend type annotations
jahodfra Jan 31, 2022
aedfa12
Merge branch 'master' into f_types
sgnn7 Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions datadog/dogstatsd/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,13 @@ def increment(
"""
self._report(metric, "c", value, tags, sample_rate)

def decrement(self, metric, value=1, tags=None, sample_rate=None):
def decrement(
self,
metric, # type: Text
value=1, # type: float
tags=None, # type: Optional[List[str]]
sample_rate=None, # type: Optional[float]
): # type(...) -> None
"""
Decrement a counter, optionally setting a value, tags and a sample
rate.
Expand All @@ -581,7 +587,13 @@ def decrement(self, metric, value=1, tags=None, sample_rate=None):
metric_value = -value if value else value
self._report(metric, "c", metric_value, tags, sample_rate)

def histogram(self, metric, value, tags=None, sample_rate=None):
def histogram(
self,
metric, # type: Text
value, # type: float
tags=None, # type: Optional[List[str]]
sample_rate=None, # type: Optional[float]
): # type(...) -> None
"""
Sample a histogram value, optionally setting tags and a sample rate.
Expand All @@ -590,7 +602,13 @@ def histogram(self, metric, value, tags=None, sample_rate=None):
"""
self._report(metric, "h", value, tags, sample_rate)

def distribution(self, metric, value, tags=None, sample_rate=None):
def distribution(
self,
metric, # type: Text
value, # type: float
tags=None, # type: Optional[List[str]]
sample_rate=None, # type: Optional[float]
): # type(...) -> None
"""
Send a global distribution value, optionally setting tags and a sample rate.
Expand All @@ -599,7 +617,13 @@ def distribution(self, metric, value, tags=None, sample_rate=None):
"""
self._report(metric, "d", value, tags, sample_rate)

def timing(self, metric, value, tags=None, sample_rate=None):
def timing(
self,
metric, # type: Text
value, # type: float
tags=None, # type: Optional[List[str]]
sample_rate=None, # type: Optional[float]
): # type(...) -> None
"""
Record a timing, optionally setting tags and a sample rate.
Expand Down