Conversation
Keyword arguments not supported on py2.7
remeh
previously approved these changes
Sep 5, 2023
Contributor
remeh
left a comment
There was a problem hiding this comment.
Left a small remark, approved for a future merge as the rest looks good to me!
| sock = None | ||
| try: | ||
| sock = socket.socket(af, ty, proto) | ||
| sock.connect(addr) |
Contributor
There was a problem hiding this comment.
Since your change, are you sure it's OK to call the settimeout after the call to connect? Could be for UDP but might be worth preserving the old behavior: https://docs.python.org/3/library/socket.html#timeouts-and-the-connect-method
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure socket timeout doesn't make any difference for udp sockets, but just for symmetry I updated the code to have the order same between udp and uds.
This makes no difference with udp sockets, but do it anyway for symmetry and ease of maintenace.
remeh
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add IPv6 support for hostnames and literal addresses.
Description of the Change
Call
getaddrinfoto parse and resolve an internet address before creating the socket. Try in a loop until one address succeeds.For backwards compatibility, prefer ipv4 addresses: ipv4-only agent should still work even if hostname (e.g.
localhost) resolves to both ipv4 and ipv6 address and ipv6 is preferred by the OS. This also matches behavior of Golang.Alternate Designs
Possible Drawbacks
Address order specified in
gai.confis ignored, which may lead to inconsistencies with other applications.Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.