Conversation
initialize reassigns socket_path property on the global statsd instance, but the client_transport tag was computed in the constructor and never updated, causing client to misreport transport as udp when a unix socket was actually used. This patch makes the tag dynamic and updates it every time the socket_path property is updated.
vickenty
changed the title
vickenty
added
the
changelog/Fixed
scottopell
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This patch makes the
client_transporttag dynamic and updates it every time thesocket_pathproperty is updated.Description of the Change
datadog.initializereassignssocket_pathproperty on the global statsd instance, but theclient_transporttag was computed in the constructor and never updated, causing client to misreport transport as udp when a unix socket was actually used.Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.