Skip to content

[AMLII-2170] fix removed/renamed function flush#868

Merged
amaskara-dd merged 3 commits intomasterfrom
fix-missing-flush-function
Nov 15, 2024
Merged

[AMLII-2170] fix removed/renamed function flush#868
amaskara-dd merged 3 commits intomasterfrom
fix-missing-flush-function

Conversation

@andrewqian2001datadog
Copy link
Copy Markdown
Contributor

@andrewqian2001datadog andrewqian2001datadog commented Nov 15, 2024 •
edited
Loading

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Renaming the flush function caused a breaking change

Issue 1, 2

Description of the Change

Add the flush function back to the api and revert renaming of another global variable.

Verification Process

Unit tests.

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@andrewqian2001datadog andrewqian2001datadog self-assigned this Nov 15, 2024
@andrewqian2001datadog andrewqian2001datadog added the kind/bug Bug related issue label Nov 15, 2024
@andrewqian2001datadog andrewqian2001datadog marked this pull request as ready for review November 15, 2024 15:39
@andrewqian2001datadog andrewqian2001datadog requested a review from a team as a code owner November 15, 2024 15:39
@andrewqian2001datadog andrewqian2001datadog requested a review from a team November 15, 2024 15:39
@andrewqian2001datadog andrewqian2001datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Nov 15, 2024
@amaskara-dd amaskara-dd merged commit 362e187 into master Nov 15, 2024
@amaskara-dd amaskara-dd deleted the fix-missing-flush-function branch November 15, 2024 17:25
ddrthall pushed a commit that referenced this pull request Nov 18, 2024
@andrewqian2001datadog @ddrthall
[AMLII-2170] fix removed/renamed function flush (#868)
719c697 
* fix missing function that was renamed

* fix lint

* change variable name back to original
@skarimo skarimo mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosroman carlosroman carlosroman approved these changes

Assignees

@andrewqian2001datadog andrewqian2001datadog

Labels

changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewqian2001datadog @carlosroman @amaskara-dd