Skip to content

Add Cardinality common field#883

Merged
carlosroman merged 1 commit intomasterfrom
CONTP-582/wassim.dhif/implement-cardinality-common-field
Jun 2, 2025
Merged

Add Cardinality common field#883
carlosroman merged 1 commit intomasterfrom
CONTP-582/wassim.dhif/implement-cardinality-common-field

Conversation

@wdhif
Copy link
Copy Markdown
Member

@wdhif wdhif commented Jan 14, 2025 •
edited
Loading

What does this PR do?

Implement the card: common field to DogStatsD Datagram spec. This new field is used to override the Agent cardinality.

Description of the Change

Adds a new cardinality setting that can be either:

  • Defined globally as an option
  • Override on a per-metrics basis

This settings is then send as the card: common field.

Alternate Designs

Possible Drawbacks

None

Verification Process

Unit tests have been implemented to test the feature. QA has been done manually and can be found in DataDog/datadog-agent#32917.

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@wdhif wdhif changed the title feat(origindetection): implement cardinality common field Add Cardinality common field Jan 14, 2025
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 bot reviewed Jan 14, 2025
View reviewed changes
@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch 4 times, most recently from 4f4fc36 to a31858a Compare January 15, 2025 11:05
@wdhif wdhif added the changelog/Added Added features results into a minor version bump label Jan 15, 2025
@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch 2 times, most recently from 39739aa to 561c672 Compare January 15, 2025 11:22
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 bot reviewed Jan 15, 2025
View reviewed changes
@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch 20 times, most recently from 9bfa236 to 25d7aec Compare January 17, 2025 14:51
@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch 4 times, most recently from d3b3d72 to 324c61b Compare January 23, 2025 14:38
@wdhif wdhif marked this pull request as ready for review January 23, 2025 14:45
@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch from 324c61b to 34e626f Compare January 23, 2025 14:51
@tobz
Copy link
Copy Markdown
Member

tobz commented Jan 29, 2025

What happens when this is used with an Agent version that doesn't have support for the structured card field? 🤔

@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch from 34e626f to d8b986e Compare January 31, 2025 14:20
@wdhif wdhif requested a review from a team as a code owner January 31, 2025 14:20
@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch from d8b986e to 09092f1 Compare January 31, 2025 14:34
@wdhif
Copy link
Copy Markdown
Member Author

wdhif commented Jan 31, 2025

What happens when this is used with an Agent version that doesn't have support for the structured card field? 🤔

Hey @tobz 👋 The Agent will simply discard the unknown common field and the Agent cardinality (low by default) will be applied. I've just tested using Agent v7.60.0 and the low cardinality.

@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch from 09092f1 to 99bdf37 Compare January 31, 2025 17:01
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2025

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Mar 3, 2025
carlosroman
carlosroman reviewed Mar 12, 2025
View reviewed changes
@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch from 99bdf37 to 5a79ab8 Compare March 13, 2025 10:25
@wdhif wdhif requested a review from a team as a code owner March 13, 2025 10:25
@wdhif
feat(origindetection): implement cardinality common field
8c2f1fc 
Signed-off-by: Wassim DHIF <wassim.dhif@datadoghq.com>
@wdhif wdhif force-pushed the CONTP-582/wassim.dhif/implement-cardinality-common-field branch from 5a79ab8 to 8c2f1fc Compare March 13, 2025 10:38
carlosroman
carlosroman approved these changes May 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@carlosroman
Copy link
Copy Markdown
Contributor

carlosroman commented Jun 2, 2025

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow bot commented Jun 2, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-02 09:56:51 UTC ℹ️ Start processing command /merge

2025-06-02 09:56:55 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).

2025-06-02 11:30:15 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@carlosroman carlosroman merged commit e54bbac into master Jun 2, 2025
17 checks passed
@carlosroman carlosroman deleted the CONTP-582/wassim.dhif/implement-cardinality-common-field branch June 2, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@carlosroman carlosroman carlosroman approved these changes

@amaskara-dd amaskara-dd amaskara-dd approved these changes

Assignees

No one assigned

Labels

changelog/Added Added features results into a minor version bump mergequeue-status: done stale Stale - Bot reminder

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wdhif @tobz @carlosroman @amaskara-dd