Merged
Conversation
…__.py got formatted by black
…consistently tagged hosts.
amaskara-dd
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only fix one issue, or add one feature, at the time.
The pull request must update the test suite to demonstrate the changed functionality.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.
What does this PR do?
Add hosts endpoint. See ##876.
Description of the Change
Added the hosts endpoint so I can get a host list without having to remember anything. The last commit was to fix cassettes that were generated with an incorrect app key.
Alternate Designs
I considered adding to the "host" mode instead of creating a new "hosts" mode. Our endpoint is "hosts" so I used that naming convention.
Possible Drawbacks
N/A?
Verification Process
I tested in an Ubuntu VM with keys to the expert-services sandbox.
I ran flake8 tests via python -m tox -c tox.ini -e flake8
I ran and passed integration tests via python -m tox -c tox.ini -- -k hosts
Builds failed, but I assume that has to do with my environment rather than the change.
Additional Notes
I created a PR yesterday without the cassettes because it tested fine in my VM. The automated test failed here, so I added the cassettes today.
Release Notes
Added the hosts endpoints for the Datadog API. dog hosts list returns a list of all hosts. dog hosts totals returns counts of active hosts. Datadog documentation.
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.