Conversation
As soon as the `allow_profiling` flag was set in the configuration, it was considered `True` because a cast was missing.
olivielpeau
approved these changes
Jun 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
allow_profilingconfiguration field isn't properly converted to a boolean (and is then a string), + is default value is True when not set.It means that when tested again the
developer_modeboolean, only thedeveloper_modevalue matters becauseallow_profilingis always True either because it is a non-empty string, or because it has the default valueTrue. The only way of setting it to false is to set it to an empty string in the configuration (allow_profiling: "").In other words:
It is only an issue when the
developer_modeis enabled.