feat: Add dd-win-prof as a dependency, built on Windows when DD_ENABLE_PROFILER=ON#157
Closed
awforsythe wants to merge 7 commits into
Closed
feat: Add dd-win-prof as a dependency, built on Windows when DD_ENABLE_PROFILER=ON#157awforsythe wants to merge 7 commits into
DD_ENABLE_PROFILER=ON#157awforsythe wants to merge 7 commits into
Conversation
fuzzybinary
previously approved these changes
Mar 3, 2026
fuzzybinary
left a comment
Member
There was a problem hiding this comment.
This probably doesn't have too be pulled into main -- we can leave this on an experimental branch so long as the Profiling team knows how to get it.
e279c33 to
cb9147e
Compare
|
✅ Code Quality ✅ Code Vulnerabilities ✅ Library Vulnerabilities ✅ Secrets 🎉 All green!🛠️ No new code quality issues 🔗 Commit SHA: 1a4202f | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
cb9147e to
7d6db18
Compare
7d6db18 to
1a4202f
Compare
Contributor
Author
|
This branch has been supplanted by the profiling team's more recent work; closing this PR in favor of #185. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates dd-win-prof into the SDK's CMake build, allowing it to be included and built as a dependency when
DD_ENABLE_PROFILERis set and the SDK is being built for Windows.As of this PR, on a Windows VM, from a fresh copy of
dd-sdk-cpp, I can configure and build with-DDD_ENABLE_PROFILER=ON:The
dd-sdk-cppCMake project will pull indd-win-profviaFetchContent(temporarily using branchaforsythe/cmake), build it from source, and add it as a dependency ofdd-sdk-cpp, such that we could includedd-win-profheaders and call its public functions from the SDK.Additionally, the
datadog_enableanddatadog_installconvenience functions (used to add Datadog SDK support to downstream projects, like the exampledd_native_replprogram) now handle copyingdd-win-prof.dllanddatadog_profiling_ffi.dllto the final output directory.So once our CMake build completes, we have an example program with all required artifacts in place:
This PR does not attempt to integrate
dd-win-profinto the SDK, nor does it add any calls todd-win-prof's API. This PR is concerned only with ensuring that we can builddd-win-profseamlessly alongside the SDK.