[RUM-13565] [V3] Fix incorrect encoding of internal attributes#1091
Merged
cdn34dd merged 1 commit intoJan 5, 2026
Merged
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 231f76f | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
95c9976 to
02bce97
Compare
02bce97 to
231f76f
Compare
sbarrio
reviewed
Jan 5, 2026
| encodeAttributesInPlace(v, result, [k], allEncoders, context); | ||
| // Internal SDK attributes (starting with '_dd.') should not be flattened | ||
| // as they have a specific structure expected by the native SDK | ||
| if (k.startsWith('_dd.')) { |
sbarrio
approved these changes
Jan 5, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevent the flattening of nested attributes when handling internal attributes, so that native functionality remains unchanged.
Motivation
Incorrect handing of internal attributes:
Correct V2 - https://mobile-integration.datadoghq.com/rum/sessions?query=%40type%3Asession %40application.id%3A056b6201-48cb-4acc-9fbc-48507b8e3e12&agg_m=count&agg_m_source=base&agg_t=count&event=AwAAAZtvNgjglADQwwAAABhBWnR2TmhLOUFBQXNpR0tzbE8ycHpBQUUAAAAkMDE5YjZmMzYtNWMzNS00ZDRmLWEwZGQtZThmY2FjODAxMzc3AAAAJg&fromUser=false&from_ts=1767028516231&to_ts=1767114916231&live=true
Incorrect V3 - https://mobile-integration.datadoghq.com/rum/sessions?query=%40type%3Asession %40application.id%3A056b6201-48cb-4acc-9fbc-48507b8e3e12&agg_m=count&agg_m_source=base&agg_t=count&event=AwAAAZtwObGPi4g5iAAAABhBWnR3T2I5TUFBREFZUVROTzQ1czhRQUQAAAAkZDE5YjcwMzktYjE4Zi00MDEzLWE4Y2QtMDI5N2E2OTZmNWFlAAAAAA&fromUser=false&from_ts=1767028752423&to_ts=1767115152423&live=true
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)