feat: Report host information in telemetry#118
Merged
Conversation
- Collect informations on the Operating System and the CPU architecture - Report those informations in telemetry
dmehala
commented
May 16, 2024
pablomartinezbernardo
approved these changes
May 16, 2024
Contributor
pablomartinezbernardo
left a comment
pablomartinezbernardo
left a comment
There was a problem hiding this comment.
Small comment, LGTM
| std::shared_ptr<Logger> logger_; | ||
| HostInfo host_info_; | ||
| TracerSignature tracer_signature_; | ||
| std::string hostname_; |
Contributor
There was a problem hiding this comment.
We should be able to remove hostname_, right?
Contributor
Author
There was a problem hiding this comment.
Indeed. Thank you.
EDIT: fixed in 316ebbb
- Set debug header only if debug is enabled - Keep in memory uname result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The telemetry implementation was missing some host information. This PR adds those.
Content: