feat!: Set a default service name (DD_SERVICE) when no service is configured#158
Merged
Merged
Conversation
BenchmarksBenchmark execution time: 2024-10-07 14:09:05 Comparing candidate commit bb5065c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
4bd244f to
51d33e8
Compare
…ame value when none is provided by DD_SERVICE or configuration Issues: APMAPI-709
…figuration so we can test default behaviors Issues: APMAPI-708 , APMAPI-709
51d33e8 to
c312c99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 72 72
Lines 3804 3806 +2
=======================================
+ Hits 3601 3603 +2
Misses 203 203 ☔ View full report in Codecov by Sentry. |
dmehala
approved these changes
Oct 6, 2024
Co-authored-by: Damien Mehala <damien.mehala@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a default service for the configuration if none was set in the
DD_SERVICEenvironment variable or user configuration. This is a breaking change as previously a missing service would throw a configuration initialization error.The default value will be set to the name of the executable.
Motivation
This aligns the cpp tracer behavior for an unconfigured
DD_SERVICEwith the expected behavior of all the tracers in our Config Consistency initiative.Additional Notes
Also updates the parametric test so that the DD_ENV behavior works as expected.
This has been tested on Ubuntu 24.04 (run on a Windows machine in WSL), Windows 11, and macOS Monterey
Jira ticket: APMAPI-709 APMAPI-708