Fix build on Mac OS/libc++; allow setting build type#6
Closed
cataphract wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi, @cataphract, thanks for the contribution. Could you explain these changes? |
Merged
Contributor
|
Thanks again for this contribution. Recently, Caleb has experimented with building this library on his Macbook, but he found that another approach was needed. Then it turned out he didn't need to build this library on his Macbook after all. I played around with a CMake-only libcurl build, but that had issues because it is unable to produce an archive (you only get For now, we will not support Darwin, but I will use this PR as a reference when we eventually do add support, somehow. |
cataphract
pushed a commit
to cataphract/dd-trace-cpp
that referenced
this pull request
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.