Skip to content

Generate 128-bit trace id by default #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmehala merged 1 commit into from
Nov 16, 2023
Merged

Generate 128-bit trace id by default #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datadog/tracer_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ struct TracerConfig {
// IDs. If true, the tracer will generate 128-bit trace IDs. If false, the
// tracer will generate 64-bit trace IDs. `trace_id_128_bit` is overridden by
// the `DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED` environment variable.
bool trace_id_128_bit = false;
bool trace_id_128_bit = true;

// `runtime_id` denotes the current run of the application in which the tracer
// is embedded. If `runtime_id` is not specified, then it defaults to a
Expand Down
2 changes: 1 addition & 1 deletion test/test_tracer_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ TEST_CASE("configure 128-bit trace IDs") {
TracerConfig config;
config.defaults.service = "testsvc";

SECTION("defaults to false") { REQUIRE(config.trace_id_128_bit == false); }
SECTION("defaults to true") { REQUIRE(config.trace_id_128_bit == true); }

SECTION("value honored in finalizer") {
const auto value = GENERATE(true, false);
Expand Down