docs(instrumentation): add cross-cutting advice patterns reference doc#11456
Draft
jandro996 wants to merge 1 commit into
Draft
docs(instrumentation): add cross-cutting advice patterns reference doc#11456jandro996 wants to merge 1 commit into
jandro996 wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Adds docs/instrumentation/advice-patterns.md covering helperClassNames nested class requirement, muzzleDirective non-null constraint, FieldValue typing, suppress-Throwable loop limitation, Config.get() muzzle failure, reflection cache for version-variant return types, and business logic extraction rule. Adds dd-java-agent/instrumentation/AGENTS.md as a lean index.
jandro996
force-pushed
the
alejandro.gonzalez/docs-instrumentation
branch
2 times, most recently
from
3a07186 to
792d8b7
Compare
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master resultsStartup Time
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/instrumentation/advice-patterns.md: cross-cutting rules for@Adviceinstrumentation derived from 210+ PR reviews --helperClassNames()nested class requirement,muzzleDirective()non-null constraint inassertInversemodules,@Advice.FieldValuetyping,suppress = Throwable.classloop limitation,Config.get()muzzle failure in@RequiresRequestContextclasses, reflection cache for version-variant return types, and business logic extraction rule.dd-java-agent/instrumentation/AGENTS.mdas a lean index pointing to the extended docs.AGENTS.mdwith instrumentation patterns entry.No functional code changes.
Test plan