perf: use serverless-specific wheel in layer#17201
perf: use serverless-specific wheel in layer#17201gh-worker-dd-mergequeue-cf854d[bot] merged 47 commits intomainfrom
Conversation
Codeowners resolved as |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03405c6589
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Performance SLOsComparing candidate emmett.butler/serverless-wheels (b95b1c5) with baseline main (b1b9718) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 104.385µs (SLO: <130.000µs 📉 -19.7%) vs baseline: +3.4% Memory: ✅ 44.328MB (SLO: <46.000MB -3.6%) vs baseline: +5.5% ✅ add_inplace_aspectTime: ✅ 102.108µs (SLO: <130.000µs 📉 -21.5%) vs baseline: +0.8% Memory: ✅ 44.355MB (SLO: <46.000MB -3.6%) vs baseline: +5.9% ✅ add_inplace_noaspectTime: ✅ 28.101µs (SLO: <40.000µs 📉 -29.7%) vs baseline: -0.6% Memory: ✅ 44.389MB (SLO: <46.000MB -3.5%) vs baseline: +5.5% ✅ add_noaspectTime: ✅ 48.974µs (SLO: <70.000µs 📉 -30.0%) vs baseline: +0.3% Memory: ✅ 44.087MB (SLO: <46.000MB -4.2%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 254.926µs (SLO: <400.000µs 📉 -36.3%) vs baseline: +0.9% Memory: ✅ 44.072MB (SLO: <46.000MB -4.2%) vs baseline: +4.8% ✅ bytearray_extend_aspectTime: ✅ 663.194µs (SLO: <800.000µs 📉 -17.1%) vs baseline: +2.9% Memory: ✅ 44.003MB (SLO: <46.000MB -4.3%) vs baseline: +3.9% ✅ bytearray_extend_noaspectTime: ✅ 268.481µs (SLO: <400.000µs 📉 -32.9%) vs baseline: +1.6% Memory: ✅ 43.993MB (SLO: <46.000MB -4.4%) vs baseline: +4.6% ✅ bytearray_noaspectTime: ✅ 140.849µs (SLO: <300.000µs 📉 -53.1%) vs baseline: +3.5% Memory: ✅ 44.376MB (SLO: <46.000MB -3.5%) vs baseline: +5.5% ✅ bytes_aspectTime: ✅ 224.754µs (SLO: <300.000µs 📉 -25.1%) vs baseline: +2.1% Memory: ✅ 44.251MB (SLO: <46.000MB -3.8%) vs baseline: +5.4% ✅ bytes_noaspectTime: ✅ 133.603µs (SLO: <200.000µs 📉 -33.2%) vs baseline: +0.4% Memory: ✅ 44.068MB (SLO: <46.000MB -4.2%) vs baseline: +4.0% ✅ bytesio_aspectTime: ✅ 3.802ms (SLO: <5.000ms 📉 -24.0%) vs baseline: +0.4% Memory: ✅ 43.943MB (SLO: <46.000MB -4.5%) vs baseline: +4.3% ✅ bytesio_noaspectTime: ✅ 316.781µs (SLO: <420.000µs 📉 -24.6%) vs baseline: -0.5% Memory: ✅ 44.036MB (SLO: <46.000MB -4.3%) vs baseline: +4.0% ✅ capitalize_aspectTime: ✅ 90.322µs (SLO: <300.000µs 📉 -69.9%) vs baseline: +1.0% Memory: ✅ 44.001MB (SLO: <46.000MB -4.3%) vs baseline: +3.9% ✅ capitalize_noaspectTime: ✅ 272.753µs (SLO: <300.000µs -9.1%) vs baseline: +7.5% Memory: ✅ 44.382MB (SLO: <46.000MB -3.5%) vs baseline: +5.5% ✅ casefold_aspectTime: ✅ 90.495µs (SLO: <500.000µs 📉 -81.9%) vs baseline: +1.1% Memory: ✅ 43.946MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 304.253µs (SLO: <500.000µs 📉 -39.1%) vs baseline: -0.8% Memory: ✅ 43.941MB (SLO: <46.000MB -4.5%) vs baseline: +3.7% ✅ decode_aspectTime: ✅ 86.580µs (SLO: <100.000µs 📉 -13.4%) vs baseline: -0.4% Memory: ✅ 44.009MB (SLO: <46.000MB -4.3%) vs baseline: +4.4% ✅ decode_noaspectTime: ✅ 154.604µs (SLO: <210.000µs 📉 -26.4%) vs baseline: +2.1% Memory: ✅ 43.979MB (SLO: <46.000MB -4.4%) vs baseline: +3.9% ✅ encode_aspectTime: ✅ 84.605µs (SLO: <200.000µs 📉 -57.7%) vs baseline: -0.3% Memory: ✅ 44.010MB (SLO: <46.000MB -4.3%) vs baseline: +4.5% ✅ encode_noaspectTime: ✅ 144.508µs (SLO: <200.000µs 📉 -27.7%) vs baseline: +2.5% Memory: ✅ 44.071MB (SLO: <46.000MB -4.2%) vs baseline: +4.1% ✅ format_aspectTime: ✅ 14.600ms (SLO: <19.200ms 📉 -24.0%) vs baseline: ~same Memory: ✅ 44.058MB (SLO: <46.000MB -4.2%) vs baseline: +4.5% ✅ format_map_aspectTime: ✅ 16.393ms (SLO: <21.500ms 📉 -23.8%) vs baseline: -0.2% Memory: ✅ 44.057MB (SLO: <46.000MB -4.2%) vs baseline: +3.8% ✅ format_map_noaspectTime: ✅ 375.971µs (SLO: <500.000µs 📉 -24.8%) vs baseline: +0.8% Memory: ✅ 44.320MB (SLO: <46.000MB -3.7%) vs baseline: +5.4% ✅ format_noaspectTime: ✅ 313.891µs (SLO: <500.000µs 📉 -37.2%) vs baseline: +3.2% Memory: ✅ 44.052MB (SLO: <46.000MB -4.2%) vs baseline: +3.8% ✅ index_aspectTime: ✅ 137.333µs (SLO: <300.000µs 📉 -54.2%) vs baseline: 📈 +11.3% Memory: ✅ 44.355MB (SLO: <46.000MB -3.6%) vs baseline: +5.6% ✅ index_noaspectTime: ✅ 40.449µs (SLO: <300.000µs 📉 -86.5%) vs baseline: -0.5% Memory: ✅ 43.882MB (SLO: <46.000MB -4.6%) vs baseline: +3.4% ✅ join_aspectTime: ✅ 211.838µs (SLO: <300.000µs 📉 -29.4%) vs baseline: -1.1% Memory: ✅ 44.414MB (SLO: <46.000MB -3.4%) vs baseline: +5.7% ✅ join_noaspectTime: ✅ 145.604µs (SLO: <300.000µs 📉 -51.5%) vs baseline: +2.0% Memory: ✅ 44.045MB (SLO: <46.000MB -4.3%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 500.733µs (SLO: <700.000µs 📉 -28.5%) vs baseline: ~same Memory: ✅ 44.379MB (SLO: <46.000MB -3.5%) vs baseline: +5.5% ✅ ljust_noaspectTime: ✅ 284.307µs (SLO: <300.000µs -5.2%) vs baseline: +9.8% Memory: ✅ 43.943MB (SLO: <46.000MB -4.5%) vs baseline: +3.7% ✅ lower_aspectTime: ✅ 300.550µs (SLO: <500.000µs 📉 -39.9%) vs baseline: +2.4% Memory: ✅ 44.355MB (SLO: <46.000MB -3.6%) vs baseline: +5.6% ✅ lower_noaspectTime: ✅ 235.746µs (SLO: <300.000µs 📉 -21.4%) vs baseline: -0.1% Memory: ✅ 43.965MB (SLO: <46.000MB -4.4%) vs baseline: +3.9% ✅ lstrip_aspectTime: ✅ 0.279ms (SLO: <3.000ms 📉 -90.7%) vs baseline: +2.8% Memory: ✅ 44.083MB (SLO: <46.000MB -4.2%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.178ms (SLO: <3.000ms 📉 -94.1%) vs baseline: +0.9% Memory: ✅ 43.976MB (SLO: <46.000MB -4.4%) vs baseline: +3.9% ✅ modulo_aspectTime: ✅ 14.290ms (SLO: <18.750ms 📉 -23.8%) vs baseline: -0.7% Memory: ✅ 44.123MB (SLO: <46.000MB -4.1%) vs baseline: +4.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.843ms (SLO: <19.350ms 📉 -23.3%) vs baseline: +0.5% Memory: ✅ 44.070MB (SLO: <46.000MB -4.2%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 14.424ms (SLO: <18.900ms 📉 -23.7%) vs baseline: ~same Memory: ✅ 44.124MB (SLO: <46.000MB -4.1%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.596ms (SLO: <19.150ms 📉 -23.8%) vs baseline: -0.2% Memory: ✅ 44.102MB (SLO: <46.000MB -4.1%) vs baseline: +4.5% ✅ modulo_noaspectTime: ✅ 0.366ms (SLO: <3.000ms 📉 -87.8%) vs baseline: +0.6% Memory: ✅ 44.048MB (SLO: <46.000MB -4.2%) vs baseline: +4.0% ✅ replace_aspectTime: ✅ 18.478ms (SLO: <24.000ms 📉 -23.0%) vs baseline: +0.4% Memory: ✅ 44.183MB (SLO: <46.000MB -3.9%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 280.882µs (SLO: <400.000µs 📉 -29.8%) vs baseline: +0.2% Memory: ✅ 44.089MB (SLO: <46.000MB -4.2%) vs baseline: +3.9% ✅ repr_aspectTime: ✅ 320.128µs (SLO: <420.000µs 📉 -23.8%) vs baseline: +2.4% Memory: ✅ 44.269MB (SLO: <46.000MB -3.8%) vs baseline: +5.1% ✅ repr_noaspectTime: ✅ 46.777µs (SLO: <90.000µs 📉 -48.0%) vs baseline: ~same Memory: ✅ 43.955MB (SLO: <46.000MB -4.4%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 395.627µs (SLO: <500.000µs 📉 -20.9%) vs baseline: +1.1% Memory: ✅ 44.016MB (SLO: <46.000MB -4.3%) vs baseline: +4.4% ✅ rstrip_noaspectTime: ✅ 185.624µs (SLO: <300.000µs 📉 -38.1%) vs baseline: +0.9% Memory: ✅ 44.188MB (SLO: <46.000MB -3.9%) vs baseline: +4.1% ✅ slice_aspectTime: ✅ 182.427µs (SLO: <300.000µs 📉 -39.2%) vs baseline: -1.4% Memory: ✅ 44.355MB (SLO: <46.000MB -3.6%) vs baseline: +5.7% ✅ slice_noaspectTime: ✅ 53.851µs (SLO: <90.000µs 📉 -40.2%) vs baseline: -1.0% Memory: ✅ 43.925MB (SLO: <46.000MB -4.5%) vs baseline: +3.9% ✅ stringio_aspectTime: ✅ 4.535ms (SLO: <5.000ms -9.3%) vs baseline: 📈 +18.3% Memory: ✅ 43.918MB (SLO: <46.000MB -4.5%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 349.768µs (SLO: <500.000µs 📉 -30.0%) vs baseline: +0.4% Memory: ✅ 43.955MB (SLO: <46.000MB -4.4%) vs baseline: +3.7% ✅ strip_aspectTime: ✅ 280.767µs (SLO: <350.000µs 📉 -19.8%) vs baseline: +2.6% Memory: ✅ 44.325MB (SLO: <46.000MB -3.6%) vs baseline: +5.4% ✅ strip_noaspectTime: ✅ 177.284µs (SLO: <240.000µs 📉 -26.1%) vs baseline: +1.1% Memory: ✅ 44.034MB (SLO: <46.000MB -4.3%) vs baseline: +3.8% ✅ swapcase_aspectTime: ✅ 338.041µs (SLO: <500.000µs 📉 -32.4%) vs baseline: +0.9% Memory: ✅ 44.063MB (SLO: <46.000MB -4.2%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 272.533µs (SLO: <400.000µs 📉 -31.9%) vs baseline: +0.7% Memory: ✅ 43.941MB (SLO: <46.000MB -4.5%) vs baseline: +3.7% ✅ title_aspectTime: ✅ 325.452µs (SLO: <500.000µs 📉 -34.9%) vs baseline: +1.4% Memory: ✅ 44.310MB (SLO: <46.000MB -3.7%) vs baseline: +5.5% ✅ title_noaspectTime: ✅ 259.453µs (SLO: <400.000µs 📉 -35.1%) vs baseline: -0.7% Memory: ✅ 43.996MB (SLO: <46.000MB -4.4%) vs baseline: +3.6% ✅ translate_aspectTime: ✅ 498.322µs (SLO: <700.000µs 📉 -28.8%) vs baseline: +1.6% Memory: ✅ 43.983MB (SLO: <46.000MB -4.4%) vs baseline: +4.6% ✅ translate_noaspectTime: ✅ 429.458µs (SLO: <500.000µs 📉 -14.1%) vs baseline: ~same Memory: ✅ 44.371MB (SLO: <46.000MB -3.5%) vs baseline: +5.3% ✅ upper_aspectTime: ✅ 293.987µs (SLO: <500.000µs 📉 -41.2%) vs baseline: -1.7% Memory: ✅ 44.261MB (SLO: <46.000MB -3.8%) vs baseline: +5.3% ✅ upper_noaspectTime: ✅ 237.871µs (SLO: <400.000µs 📉 -40.5%) vs baseline: +0.7% Memory: ✅ 43.927MB (SLO: <46.000MB -4.5%) vs baseline: +3.7% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 513.741µs (SLO: <700.000µs 📉 -26.6%) vs baseline: 📈 +23.3% Memory: ✅ 44.067MB (SLO: <46.000MB -4.2%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 427.773µs (SLO: <700.000µs 📉 -38.9%) vs baseline: +0.5% Memory: ✅ 44.202MB (SLO: <46.000MB -3.9%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 622.480µs (SLO: <700.000µs 📉 -11.1%) vs baseline: -0.4% Memory: ✅ 44.089MB (SLO: <46.000MB -4.2%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 630.413µs (SLO: <700.000µs -9.9%) vs baseline: +0.2% Memory: ✅ 44.145MB (SLO: <46.000MB -4.0%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 349.774µs (SLO: <700.000µs 📉 -50.0%) vs baseline: +1.2% Memory: ✅ 44.017MB (SLO: <46.000MB -4.3%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 356.797µs (SLO: <700.000µs 📉 -49.0%) vs baseline: +1.5% Memory: ✅ 44.118MB (SLO: <46.000MB -4.1%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 484.289µs (SLO: <700.000µs 📉 -30.8%) vs baseline: -1.0% Memory: ✅ 44.053MB (SLO: <46.000MB -4.2%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 491.700µs (SLO: <700.000µs 📉 -29.8%) vs baseline: -1.1% Memory: ✅ 44.045MB (SLO: <46.000MB -4.2%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 375.599µs (SLO: <700.000µs 📉 -46.3%) vs baseline: +1.0% Memory: ✅ 44.077MB (SLO: <46.000MB -4.2%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 73.690µs (SLO: <700.000µs 📉 -89.5%) vs baseline: +1.3% Memory: ✅ 44.083MB (SLO: <46.000MB -4.2%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 456.108µs (SLO: <700.000µs 📉 -34.8%) vs baseline: +1.3% Memory: ✅ 44.031MB (SLO: <46.000MB -4.3%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 465.724µs (SLO: <700.000µs 📉 -33.5%) vs baseline: +1.5% Memory: ✅ 44.091MB (SLO: <46.000MB -4.2%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.397µs (SLO: <20.000µs 📉 -88.0%) vs baseline: 📈 +13.2% Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 153.601µs (SLO: <220.000µs 📉 -30.2%) vs baseline: +2.8% Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 2.478µs (SLO: <20.000µs 📉 -87.6%) vs baseline: -1.2% Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.4% ✅ 1-distribution-metrics-100-timesTime: ✅ 165.586µs (SLO: <230.000µs 📉 -28.0%) vs baseline: +1.3% Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.039µs (SLO: <20.000µs 📉 -89.8%) vs baseline: +3.4% Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.4% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.867µs (SLO: <150.000µs -8.8%) vs baseline: +1.2% Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 2.331µs (SLO: <20.000µs 📉 -88.3%) vs baseline: +3.5% Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.5% ✅ 1-rate-metrics-100-timesTime: ✅ 169.397µs (SLO: <250.000µs 📉 -32.2%) vs baseline: +4.1% Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 15.483ms (SLO: <22.000ms 📉 -29.6%) vs baseline: +1.8% Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +4.4% ✅ 100-distribution-metrics-100-timesTime: ✅ 1.736ms (SLO: <2.550ms 📉 -31.9%) vs baseline: ~same Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +4.5% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: +0.5% Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.5% ✅ 100-rate-metrics-100-timesTime: ✅ 1.763ms (SLO: <2.550ms 📉 -30.9%) vs baseline: +4.3% Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 3.711µs (SLO: <20.000µs 📉 -81.4%) vs baseline: +2.5% Memory: ✅ 36.667MB (SLO: <38.000MB -3.5%) vs baseline: +5.6% ✅ flush-100-metricsTime: ✅ 176.924µs (SLO: <250.000µs 📉 -29.2%) vs baseline: +0.5% Memory: ✅ 36.628MB (SLO: <38.000MB -3.6%) vs baseline: +5.6% ✅ flush-1000-metricsTime: ✅ 2.218ms (SLO: <2.500ms 📉 -11.3%) vs baseline: +0.7% Memory: ✅ 37.061MB (SLO: <38.750MB -4.4%) vs baseline: +4.6% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.751ms (SLO: <22.300ms 📉 -11.4%) vs baseline: ~same Memory: ✅ 69.601MB (SLO: <73.500MB -5.3%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.330ms (SLO: <1.450ms -8.2%) vs baseline: +0.3% Memory: ✅ 67.632MB (SLO: <71.500MB -5.4%) vs baseline: +5.0% ✅ iastTime: ✅ 19.795ms (SLO: <22.250ms 📉 -11.0%) vs baseline: +0.1% Memory: ✅ 69.583MB (SLO: <75.000MB -7.2%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.137ms (SLO: <16.550ms -8.5%) vs baseline: -0.1% Memory: ✅ 60.612MB (SLO: <61.000MB 🟡 -0.6%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 19.715ms (SLO: <21.750ms -9.4%) vs baseline: +0.5% Memory: ✅ 69.680MB (SLO: <73.500MB -5.2%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 20.080ms (SLO: <28.200ms 📉 -28.8%) vs baseline: +0.6% Memory: ✅ 69.770MB (SLO: <75.000MB -7.0%) vs baseline: +5.3% ✅ tracerTime: ✅ 19.756ms (SLO: <21.750ms -9.2%) vs baseline: +0.1% Memory: ✅ 69.606MB (SLO: <75.000MB -7.2%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 21.071ms (SLO: <23.500ms 📉 -10.3%) vs baseline: -0.6% Memory: ✅ 71.748MB (SLO: <75.000MB -4.3%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.795ms (SLO: <21.500ms -7.9%) vs baseline: ~same Memory: ✅ 69.516MB (SLO: <75.000MB -7.3%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.873ms (SLO: <17.500ms -3.6%) vs baseline: ~same Memory: ✅ 69.491MB (SLO: <75.000MB -7.3%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 19.714ms (SLO: <21.750ms -9.4%) vs baseline: +0.4% Memory: ✅ 69.541MB (SLO: <72.500MB -4.1%) vs baseline: +5.1% ✅ tracer-no-cachesTime: ✅ 17.679ms (SLO: <19.650ms 📉 -10.0%) vs baseline: +0.4% Memory: ✅ 69.530MB (SLO: <75.000MB -7.3%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 19.371ms (SLO: <20.100ms -3.6%) vs baseline: ~same Memory: ✅ 69.511MB (SLO: <75.000MB -7.3%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 19.481ms (SLO: <21.500ms -9.4%) vs baseline: ~same Memory: ✅ 69.505MB (SLO: <75.000MB -7.3%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 19.734ms (SLO: <22.000ms 📉 -10.3%) vs baseline: +1.4% Memory: ✅ 69.483MB (SLO: <73.500MB -5.5%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 3.393ms (SLO: <4.750ms 📉 -28.6%) vs baseline: +0.3% Memory: ✅ 56.741MB (SLO: <66.500MB 📉 -14.7%) vs baseline: +5.4% ✅ appsec-postTime: ✅ 2.872ms (SLO: <6.750ms 📉 -57.4%) vs baseline: -0.1% Memory: ✅ 56.761MB (SLO: <66.500MB 📉 -14.6%) vs baseline: +5.1% ✅ appsec-telemetryTime: ✅ 3.395ms (SLO: <4.750ms 📉 -28.5%) vs baseline: +1.0% Memory: ✅ 56.800MB (SLO: <66.500MB 📉 -14.6%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.880ms (SLO: <2.000ms -6.0%) vs baseline: ~same Memory: ✅ 49.349MB (SLO: <51.500MB -4.2%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.874ms (SLO: <2.000ms -6.3%) vs baseline: ~same Memory: ✅ 46.164MB (SLO: <49.000MB -5.8%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.924ms (SLO: <2.100ms -8.4%) vs baseline: -0.2% Memory: ✅ 52.553MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.356ms (SLO: <3.650ms -8.1%) vs baseline: -0.2% Memory: ✅ 56.741MB (SLO: <60.000MB -5.4%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 56.741MB (SLO: <60.000MB -5.4%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: -0.1% Memory: ✅ 56.761MB (SLO: <60.000MB -5.4%) vs baseline: +5.2% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 311.144ms (SLO: <320.950ms -3.1%) vs baseline: -0.4% Memory: ✅ 37.493MB (SLO: <38.750MB -3.2%) vs baseline: +4.9% ✅ deep-profiledTime: ✅ 328.738ms (SLO: <359.150ms -8.5%) vs baseline: -0.9% Memory: ✅ 43.962MB (SLO: <46.000MB -4.4%) vs baseline: +4.6% ✅ mediumTime: ✅ 7.305ms (SLO: <7.400ms 🟡 -1.3%) vs baseline: -0.4% Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +4.6% ✅ shallowTime: ✅ 1.023ms (SLO: <1.050ms -2.5%) vs baseline: +1.3% Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%
|
I think once that is working this part will fail: I think because the wheel will need to provide "ddtrace" and it is providing |
|
@brettlangdon yes, that's accounted for here https://github.com/DataDog/datadog-lambda-python/pull/762/changes, to be merged after this PR. |
|
should we try to land a change in we are probably going to end up with an issue with older branches anyways, since we don't pin commits in the serverless tests ci job or the serverless benchmark job, so we might need build_layers.sh to be backwards compatible :/ (I think?) |
brettlangdon
left a comment
There was a problem hiding this comment.
I worry a bit about the 3 dependent/connected repos/CIs, but in general these changes lgtm... I would have totally missed the pypi upload step 🙈
no blockers from me on these changes once you feel the lambda CI suites are operation properly and we are able to handle the older release branches which don't pin serverless repo versions
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Description
This change splits the wheel build/validate/upload jobs into "regular" and "serverless" branches, for the purpose of allowing datadog-lambda-python to use custom-built wheels.
Testing
CI passes
Risks
Risk mitigated by keeping the existing wheel upload path working as usual while refactoring it.
Additional Notes
Depended on by DataDog/datadog-lambda-python#762 and https://github.com/DataDog/serverless-tools/pull/101