[PROF-14955] Simplify transport config: API key implies agentless#60
Open
r1viollet wants to merge 1 commit into
Open
[PROF-14955] Simplify transport config: API key implies agentless#60r1viollet wants to merge 1 commit into
r1viollet wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
r1viollet
force-pushed
the
r1viollet/auto-agentless
branch
from
June 16, 2026 14:40
92be95b to
9e9b5ee
Compare
r1viollet
marked this pull request as ready for review
June 16, 2026 15:06
r1viollet
marked this pull request as draft
June 16, 2026 15:06
r1viollet
marked this pull request as ready for review
June 16, 2026 15:48
r1viollet
force-pushed
the
r1viollet/auto-agentless
branch
2 times, most recently
from
June 17, 2026 07:48
63ff01e to
c5cb64a
Compare
r1viollet
marked this pull request as draft
June 17, 2026 07:48
r1viollet
force-pushed
the
r1viollet/auto-agentless
branch
3 times, most recently
from
June 17, 2026 07:59
ebed291 to
ef10ca9
Compare
chrisnas
reviewed
Jun 17, 2026
r1viollet
force-pushed
the
r1viollet/auto-agentless
branch
2 times, most recently
from
June 17, 2026 09:24
e2bfb56 to
44812fd
Compare
r1viollet
changed the title
r1viollet
force-pushed
the
r1viollet/auto-agentless
branch
from
June 17, 2026 09:26
44812fd to
ab9a55a
Compare
r1viollet
marked this pull request as ready for review
June 17, 2026 09:28
chrisnas
reviewed
Jun 17, 2026
r1viollet
force-pushed
the
r1viollet/auto-agentless
branch
from
June 17, 2026 09:56
ab9a55a to
7771207
Compare
r1viollet
commented
Jun 17, 2026
| // Agentless mode is derived: true when an API key is configured. | ||
| bool IsAgentless() const; | ||
| // Logs a warning if agent and agentless settings conflict. | ||
| void ValidateTransportConfig() const; |
Collaborator
Author
There was a problem hiding this comment.
We could have a validate config, other fields should be checked.
r1viollet
force-pushed
the
r1viollet/auto-agentless
branch
from
June 17, 2026 10:09
7771207 to
857e43f
Compare
- Remove DD_PROFILING_AGENTLESS env var — agentless is now derived from DD_API_KEY being set, same as the CLI path (SetEndpoint). - Fix DD_TRACE_AGENT_UR typo → DD_TRACE_AGENT_URL. - Add ValidateTransportConfig: error if both API key (agentless) and agent settings (DD_TRACE_AGENT_URL/HOST/PORT) are configured. - Update README and tests.
r1viollet
force-pushed
the
r1viollet/auto-agentless
branch
from
June 17, 2026 14:40
857e43f to
6939d4e
Compare
chrisnas
reviewed
Jun 17, 2026
| return false; | ||
| } | ||
|
|
||
| if (!_pConfiguration->ValidateTransportConfig()) { |
Collaborator
There was a problem hiding this comment.
it should also be called at the end of InitializeConfiguration() so that the error could be detected before starting the profiler in SetupProfiler().
Collaborator
Author
There was a problem hiding this comment.
I think that calling it here is OK as it is the only common place. Do you think it changes the experience much?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Agentless mode is now derived from
DD_API_KEYbeing set, matching the existing CLI behavior (SetEndpoint).DD_PROFILING_AGENTLESSenv var is removed.Also fixes
DD_TRACE_AGENT_URtypo →DD_TRACE_AGENT_URL.Changes
IsAgentless()=!_apiKey.empty()— no more_isAgentLessfieldDD_PROFILING_AGENTLESSremovedValidateTransportConfig()called at config finalization (constructor +InitializeConfiguration)Testing
Agentless_ApiKeyAndSite,Agentless_ApiKeyOnly_DefaultSite,Agent_NoApiKey,ValidateTransport_ConflictingConfig_UsesAgentlessChecklist