Skip to content

[dashboards]Add dashboard 'get_all' API docs#4180

Merged
l0k0ms merged 5 commits intomasterfrom
rami/add_dashboard_get_all
Apr 10, 2019
Merged

[dashboards]Add dashboard 'get_all' API docs#4180
l0k0ms merged 5 commits intomasterfrom
rami/add_dashboard_get_all

Conversation

@enbashi
Copy link
Copy Markdown
Contributor

@enbashi enbashi commented Mar 14, 2019

@enbashi enbashi requested a review from a team as a code owner March 14, 2019 21:55
@enbashi enbashi added API Do Not Merge Just do not merge this PR :) labels Mar 14, 2019
@@ -0,0 +1,4 @@
{
'total': 2,
'dashboards': [{...}, {...}]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's show a full sample here

Copy link
Copy Markdown
Contributor

@MLaureB MLaureB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@enbashi enbashi added Do Not Merge Just do not merge this PR :) and removed Do Not Merge Just do not merge this PR :) labels Mar 19, 2019
@iddl
Copy link
Copy Markdown

iddl commented Apr 9, 2019

This looks good to merge !

Copy link
Copy Markdown
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@l0k0ms l0k0ms merged commit dd148f7 into master Apr 10, 2019
@l0k0ms l0k0ms removed the Do Not Merge Just do not merge this PR :) label Apr 10, 2019
@l0k0ms l0k0ms deleted the rami/add_dashboard_get_all branch April 10, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants