Merged
Conversation
gzussa
reviewed
Nov 14, 2019
Contributor
gzussa
left a comment
There was a problem hiding this comment.
Great job.
Some (maybe) naive questions here and there. Let's clean names as well so we are consistent within this SDK but also cross SDK. We should always have integration when mentioning providers.
regarding your testing scenarios. I trust you so thay are as complete as possible 😄
Contributor
Author
|
@gzussa Thanks for the feedback here. I've updated the PR and this is ready for another look. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for the following endpoints:
AWS
AWS LOGS
AZURE ENDPOINTS
GCP ENDPOINTS
ORIGINAL PR was here: #190
I messed up the history of that one with a rebase, but fixed in this branch. Unfortunately the comments from @mattsp1290 and @zippolyte couldn't be transferred over but their comments were addressed here.