[iOS] - Export sourcemap location env variable when Sentry detected#75
Closed
sidorchukandrew wants to merge 2 commits intoDataDog:mainfrom
Closed
[iOS] - Export sourcemap location env variable when Sentry detected#75sidorchukandrew wants to merge 2 commits intoDataDog:mainfrom
sidorchukandrew wants to merge 2 commits intoDataDog:mainfrom
Conversation
When Sentry is detected in the shell script, DataDog takes care to not interfere with it. Unfortunately, the DD CLI fails because it can no longer find the sourcemap location. I'm just copying the same sourcemap export present in the config when Sentry is NOT detected.
4 tasks
Member
|
Thank you for your contribution! I have created a separate PR for this: #84. It will be merged and released soon. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds exporting the sourcemap file location to the
ifbranch where Sentry is present in the build phase. When Sentry isn't present, it already adds this env variable export. This PR brings the Sentry case into alignment with when Sentry is not presentMotivation
Builds fail for us when we have
expo-datadogand Sentry app config plugins.I think this partly resolves this Sentry issue.
Review checklist (to be filled by reviewers)