Add Datadog-ProxySQL integration

[reyiyo]

What does this PR do?

This PR introduces a new agent check for ProxySQL which is a high performance MySQL proxy. ProxySQL is officially supported by Percona and is the recommended load balancer for Percona XtraDB Cluster.

Originally written by @ovaistariq (DataDog/dd-agent#3107) and opened as #39 and @bangpound (#97)

Motivation

ProxySQL is a commonly used database proxy in MySQL and Percona XtraDB Cluster deployments, and Datadog is a popular monitoring tool. Datadog currently doesn't have any agent check for ProxySQL, hence adding this agent check to Datadog will benefit other users in the community.

Review checklist

• PR has a meaningful title or PR has the no-changelog label attached

• Feature or bugfix has tests

• Git history is clean

• If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Not applicable.

[codecov]

Codecov Report

Merging #531 into master will increase coverage by 10.32%.
The diff coverage is 98.95%.

Impacted Files	Coverage Δ
proxysql/tests/conftest.py	100% <100%> (ø)
proxysql/tests/test_proxysql.py	100% <100%> (ø)
proxysql/datadog_checks/proxysql/__about__.py	100% <100%> (ø)
proxysql/datadog_checks/proxysql/__init__.py	100% <100%> (ø)
proxysql/tests/common.py	100% <100%> (ø)
proxysql/datadog_checks/proxysql/proxysql.py	98.05% <98.05%> (ø)
reboot_required/tests/test_reboot_required.py
aws_pricing/datadog_checks/aws_pricing/__init__.py
neutrona/tests/azure_mgmt.py
logstash/datadog_checks/logstash/__init__.py
... and 139 more

[ChristineTChen]

Hi @reyiyo, thanks for your contribution! I've made a few comments/mostly nits. Looks great so far!

[reyiyo]

Thank you very much @ChristineTChen! The requested changes are ready

[reyiyo]

Hi @ChristineTChen! I was wondering if you've had a chance to look at this PR

[ChristineTChen]

Hi! I took another look and added a few more comments. Overall looks good :)

[reyiyo]

Thank you @ChristineTChen! The requested changes are ready for review

[ruthnaebeck]

Docs review

[reyiyo]

Thank you @ruthnaebeck! The requested changes are ready for review.

[ruthnaebeck]

👍 for docs

[ChristineTChen]

Hi @reyiyo! I reviewed the metrics that the ProxySQL integration is submitting. I've left some comments on metric types.

From the metadata descriptions, it's not super clear to me why some of the rate metrics should be submitted as a rate. If the metrics should be time-normalized as rate types, then could we include that in the description or remapped name?

[ChristineTChen]

Thanks @reyiyo for taking the time to address everything! Looks good to me :)

[dsahni]

Hi @reyiyo !
After discussing internally, we think this integration would actually make a good candidate for the integrations-core repo, where it will be included with the Datadog agent installer by default. This would make it easier for you to install the integration as well, removing the step of having to build a Python wheel yourself.

We'd also like to add a default dashboard for it and look at any other enhancements/improvements that would benefit ProxySQL/Datadog users. Please let us know what you think!

[reyiyo]

Hi @dsahni !

That'd be awesome! Please let me know how do we proceed.

[hithwen]

Hi @reyiyo, we'll backport this PR to integrations-core (and then close the issue) and do the remaining work.

[FlorianVeaux]

Hello @reyiyo,
as said we've backported your integration in the integrations-core repository with this PR. I've included some additional changes that are all described in the PR description but they are mostly implementation details and don't change metrics or service_checks for the most part.

Feel free to have a look and comment if you think of anything. Any input will be appreciated!

[reyiyo]

Thank you very much @FlorianVeaux. The PR looks great. Looking forward to see it merged :)