Origin Detection: Send both container ID and entity ID#241
Merged
Conversation
wdhif
reviewed
May 10, 2024
src/test/java/com/timgroup/statsd/NonBlockingStatsDClientTest.java
Outdated
Show resolved
Hide resolved
wdhif
reviewed
May 10, 2024
src/test/java/com/timgroup/statsd/NonBlockingStatsDClientTest.java
Outdated
Show resolved
Hide resolved
wdhif
approved these changes
May 10, 2024
Co-authored-by: Wassim Dhif <wassimdhif@gmail.com>
Member
Author
Tested and confirmed with agent |
vickenty
reviewed
Jun 5, 2024
Contributor
vickenty
left a comment
vickenty
left a comment
There was a problem hiding this comment.
Could you please summarize difference in behavior in the PR description? Does the behavior depend on the agent version?
Is there a way to get old behavior? I see it mentioned on the other PRs, will it be applicable here? Might be nice to mention this too.
src/test/java/com/timgroup/statsd/NonBlockingStatsDClientTest.java
Outdated
Show resolved
Hide resolved
vickenty
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like customers to be able to retrieve container tags even when DD_ENTITY_ID is set. The current behavior does not send the container-id if the entity id is set.
This PR implements the same changes seen in these PRs:
DataDog/datadog-go#300
DataDog/datadogpy#828
Background
UDP support for origin detection was first introduced in
7.51However it was difficult to use due to the combination of settings required. With 7.54+ you can enableDD_ORIGIN_DETECTION_UNIFIEDand it will "just work".After this change with
DD_ORIGIN_DETECTION_UNIFIEDusers can control origin tags by simply changing thecardinalitysetting (tohighfor container level tags). This PR ultimately helps conform to the new origin detection architecture in the agent: Clients should send "Everything" (all data needed for origin detection), the agent should ingest everything, and cardinality controls which tags actually get sent.The old behavior is maintained by omitting the
DD_ORIGIN_DETECTION_UNIFIEDin the agent which will cause the tagger to fall back to legacy mode. This will eventually be removed.