fix(profiler): lock-free class/endpoint/context maps via StringDictionary by jbachorik · Pull Request #524 · DataDog/java-profiler

jbachorik · 2026-05-12T13:05:49Z

What does this PR do?:

Replaces the SpinLock-guarded Dictionary instances for _class_map, _string_label_map, and _context_value_map with a new StringDictionary that eliminates all locking from the read/write fast paths.

StringDictionary holds three StringDictionaryBuffer instances (_a, _b, _c) cycling through three roles via TripleBufferRotator<StringDictionaryBuffer>:

active — receives new writes (signal handlers + JNI threads), lock-free via CAS
dump — stable snapshot being read by the dump/stop thread after rotate()
scratch (clearTarget()) — two rotations behind; safe to clear by clearStandby()

_next_id is a global monotonic counter starting at 1; it is never reset between rotations, so every key gets a globally stable id for the lifetime of a profiler session.

rotate() — two-phase ID-preserving rotation (called under SignalBlocker + lockAll via rotateDictsAndRun()):

Phase 1: clearTarget()->copyFrom(*old_active) — pre-populate the scratch buffer with the current active snapshot before the rotation
_rot.rotate() — advances the ring: old active → dump, scratch → active, old dump → scratch
Drain: RefCountGuard::waitForRefCountToClear(old_active) — wait for any JNI thread mid-lookup on old active
Phase 2: new_active->copyFrom(*old_active) — catch any entries inserted between Phase 1 and the drain

lookupDuringDump(key) — called by writeClasses/writeCpool during jfr.dump() to resolve a key that may have arrived after rotate(). Probes dump buffer first, then active; inserts into both on a miss so the dump chunk contains the id.

clearAll() — called by Profiler::start(reset=true). Sets _accepting=false (prevents new RefCountGuard creation), drains all in-flight guards via RefCountGuard::waitForAllRefCountsToClear(), clears all three buffers, resets _rot, resets _next_id to 1.

bounded_lookup(key, len) (no size_limit) — signal-safe read-only probe of active; returns 0 on miss without inserting.

rotateDictsAndRun(action) — new Profiler helper that wraps dump/stop operations: acquires SignalBlocker, calls lockAll(), rotates all three dictionaries, runs the action (e.g. jfr.dump()), calls unlockAll(), then calls clearStandby() on each dictionary outside the lock.

RefCountGuard — extracted from CallTraceStorage into its own refCountGuard.h/cpp. Now also carries an outer_ptr field in RefCountSlot to keep the outer guard's buffer visible to waitForRefCountToClear during nested signal delivery. waitForAllRefCountsToClear() gains a timeout warning log when the drain exceeds the limit.

libraryPatcher_linux.cpp — adds run_with_musl_cleanup() (__attribute__((noinline, no_stack_protector))) to host the pthread_cleanup_push/pop pair in its own frame, keeping struct __ptcb out of start_routine_wrapper_spec's DEOPT-corruption zone on musl/aarch64/JDK11.

ASAN build fix (ConfigurationPresets.kt, PlatformUtils.kt) — locateLibasan() now returns libclang_rt.asan-<arch>.so when the compiler is clang (falling back to GCC's libasan otherwise). configureAsan derives the -l flag and adds -Wl,-rpath from the located library. Fixes "incompatible ASan runtimes" crash (caused by two different ASan runtimes — clang's from -fsanitize=address and GCC's from explicit -lasan — landing in the binary's NEEDED entries simultaneously).

Removed:

_class_map_lock (SpinLock) and classMapSharedGuard() / classMapTrySharedGuard() on Profiler
tryLockSharedBounded() and BoundedOptionalSharedLockGuard on SpinLock
dictionary_concurrent_ut.cpp and spinlock_bounded_ut.cpp (tests for removed locking primitives)
Profiler::flushJfr() (inlined into rotateDictsAndRun)

Motivation:

Three production crashes (PROF-14583, fingerprint v10.DAECC680F0728EAB44F26DB0B91B703F, 2026-05-06 to 2026-05-08) showed SIGSEGV in std::_Rb_tree_increment via Recording::writeCpool → Recording::writeClasses → Dictionary::collect, caused by a race between writeClasses and concurrent Dictionary::clear().

PR #516 patched this with a shared-lock, but that introduced tryLockSharedBounded(5) in the signal-handler path (walkVM). Under heavy 100 µs wall-clock load on aarch64 the bounded CAS retries were consistently exhausted, causing class lookups to return -1 and corrupting JFR recordings.

Supersedes PR #522.

Root Cause:

ebdcbc76 (Jan 20, 2026) — structural bug: classMap()->lookup() called from walkVM() without _class_map_lock, racing with Dictionary::clear() in Profiler::dump() and Profiler::start().

d6d85eb7 (Apr 23, 2026) — trigger: MallocTracer routes every sampled malloc through walkVM(), raising the collision rate to reliably hit the race in production.

Additional Notes:

clearStandby() is safe without any explicit drain because the scratch buffer (clearTarget()) is two full rotations behind active — its RefCountGuard drain was completed by the previous rotate() call, and _state_lock serializes all JFR operations so no new cycle starts before clearStandby() runs.
At most two non-empty buffers exist at any time (active + dump).
walkVM's vtable-stub class resolution remains best-effort; a proper fix via JVMTI ClassPrepare pre-population is left to a follow-up.

How to test the change?:

:ddprof-lib:gtestDebug_stringDictionary_ut — rotation, RefCountGuard, concurrent writer safety
:ddprof-lib:gtest (stress target stress_stringDictionary) — concurrent insert/lookup/rotate stress
DictionaryRotationTest (Java) — counter reset after clearStandby; correct counts after fill-path inserts
BoundMethodHandleProfilerTest (Java) — profiling smoke test for bound method handles
EndpointTest (Java) — endpoint label dictionary correctness under stop/start cycles

For Datadog employees:

If this PR touches code that signs or publishes builds or packages, or handles
credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
This PR doesn't touch any of that.
JIRA: PROF-14583

dd-octo-sts · 2026-05-12T14:22:07Z

CI Test Results

Run: #26356468123 | Commit: b2515a8 | Duration: 34m 54s (longest job)

✅ All 54 test jobs passed

Status Overview

JDK	glibc-aarch64/asan	glibc-aarch64/debug	glibc-amd64/asan	glibc-amd64/debug	musl-aarch64/debug	musl-amd64/debug
8	-	-	✅	✅	-	-
8-ibm	-	-	✅	✅	-	-
8-j9	✅	✅	✅	✅	-	-
8-librca	-	-	-	-	✅	✅
8-orcl	-	-	✅	✅	-	-
11	-	-	✅	✅	-	-
11-j9	✅	✅	✅	✅	-	-
11-librca	-	-	-	-	✅	✅
17	✅	✅	✅	✅	-	-
17-graal	✅	✅	✅	✅	-	-
17-j9	✅	✅	✅	✅	-	-
17-librca	-	-	-	-	✅	✅
21	✅	✅	✅	✅	-	-
21-graal	✅	✅	✅	✅	-	-
21-librca	-	-	-	-	✅	✅
25	✅	✅	✅	✅	-	-
25-graal	✅	✅	✅	✅	-	-
25-librca	-	-	-	-	✅	✅

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 54 | Passed: 54 | Failed: 0

Updated: 2026-05-24 18:56:48 UTC

Production crash (SIGSEGV) in Recording::cleanupUnreferencedMethods, first seen in dd-trace-java 1.56.1 after PR #327 introduced method-map cleanup. cleanupUnreferencedMethods() was called after finishChunk() released the GetLoadedClasses pins, so jvmti->Deallocate(_ptr) inside ~SharedLineNumberTable could access freed line number table memory on JVMs that reclaim JVMTI allocations on class unload. Fix: detach SharedLineNumberTable from JVMTI lifetime by copying the table into a malloc'd buffer in Lookup::fillJavaMethodInfo() and freeing the JVMTI allocation immediately. SharedLineNumberTable destructor now calls free(). As defence-in-depth, finishChunk() gains a do_cleanup parameter so cleanup runs inside the GetLoadedClasses pin window. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

On musl/aarch64/JDK11, HotSpot's deoptimisation blob (generate_deopt_blob in sharedRuntime_aarch64.cpp) rebuilds interpreter frames near the compiled frame's stack boundary, corrupting the top ~224 bytes of the thread stack where start_routine_wrapper_spec's frame lives. Two crashes follow: (a) -fstack-protector-strong inserts a canary into any frame with a non-trivially-destructed local (e.g. struct Cleanup); the canary lands in the corruption zone and fires __stack_chk_fail. (b) Even without a canary, 'return' loads the corrupted saved LR and jumps to a garbage address. Fix: no_stack_protector removes the canary; pthread_exit() replaces 'return' so LR is never used; cleanup is performed explicitly with the tid read from TLS (ProfiledThread::currentTid()), which survives frame corruption. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

JavaThread::~JavaThread / OSThread::~OSThread crashed on JDK 25 when the ddprof pthread_create hook delivered SIGVTALRM between Profiler::unregisterThread() returning and ProfiledThread::release() acquiring its internal guard. The signal handler called currentSignalSafe() and dereferenced the now-freed ProfiledThread. Fix: extract unregister_and_release(tid) — a noinline helper that holds a SignalBlocker for the entire unregister+release sequence. Both start_routine_wrapper and start_routine_wrapper_spec invoke it; the race window is eliminated without duplicating signal-masking logic. Same SignalBlocker pattern is applied to perfEvents_linux.cpp's pthread_setspecific_hook teardown path. thread.h guards clearCurrentThreadTLS() with #ifdef UNIT_TEST so it is absent from production builds; GtestTaskBuilder.kt adds -DUNIT_TEST to the gtest compiler flags so the guarded method compiles in tests. thread_teardown_safety_ut.cpp adds an acceptance-test suite (ThreadTeardownSafetyTest T-01..T-10) covering the full teardown lifecycle under signal load. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ASSERT_NE expands to a bare 'return;' on failure, which is a compile error in a function whose return type is void*. Use ADD_FAILURE + explicit 'return nullptr;' instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ufferedDictionary Replaces the SpinLock-guarded Dictionary instances for _class_map, _string_label_map, and _context_value_map with a new TripleBufferedDictionary that eliminates all locking from the read/write fast paths. TripleBufferedDictionary holds three Dictionary buffers cycling through three roles via a generic TripleBufferRotator<T> template: - active — receives new writes (signal handlers + JNI threads), lock-free via CAS - dump — snapshot being read by the dump thread; promoted from old active on rotate() - scratch — two rotations behind active; ready to be cleared lock-free The scratch role exists for safe lock-free reclamation: when a buffer enters that role, at least one full dump cycle has elapsed since it was last in the active or dump role. That grace period is much longer than any signal-handler or JNI-thread can plausibly outlive a stale active pointer, so the buffer can be freed without any explicit drain. bounded_lookup(size_limit=0) is signal-safe (no malloc) and checks the active buffer only — no fallback to older snapshots. Dead code removed: - _class_map_lock (SpinLock) - classMapSharedGuard() / classMapTrySharedGuard() on Profiler - tryLockSharedBounded() / BoundedOptionalSharedLockGuard on SpinLock - spinlock_bounded_ut.cpp / dictionary_concurrent_ut.cpp (subsumed by dictionary_ut.cpp) Motivation: three production crashes (fingerprint v10.DAECC680F0728EAB44F26DB0B91B703F) showed SIGSEGV in std::_Rb_tree_increment via writeCpool → writeClasses → Dictionary::collect, caused by a race between writeClasses and concurrent Dictionary::clear(). PR #516 patched it with a shared-lock that exhausted bounded CAS retries under heavy 100 µs wall-clock load on aarch64, causing class lookups to return -1 and corrupting JFR recordings. This change eliminates the lock entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- libraryPatcher_linux.cpp:151 — add __builtin_unreachable() after pthread_exit() - flightRecorder.cpp:607 — update pin-window comment to reflect malloc'd ownership - CleanupAfterClassUnloadTest.java:51 — fix Javadoc to describe both fix mechanisms - thread_teardown_safety_ut.cpp:43 — add SigGuard RAII to restore signal dispositions - thread_teardown_safety_ut.cpp:236 — gate T-07 on __GLIBC__; add musl cleanup path Co-Authored-By: muse <muse@noreply>

Agent-Logs-Url: https://github.com/DataDog/java-profiler/sessions/127448f3-9624-49bf-92f2-850b4f413a92 Co-authored-by: jbachorik <738413+jbachorik@users.noreply.github.com>

- Add pthread_cleanup_push/pop + noinline cleanup_unregister() to start_routine_wrapper_spec so ProfiledThread is released when the wrapped routine calls pthread_exit() or the thread is canceled - Extend CleanupAfterClassUnloadTest from AbstractDynamicClassTest to reuse generateClassBytecode/IsolatedClassLoader/tempFile helpers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- thread_teardown_safety_ut.cpp: guard T-01 sentinel with ASSERT_NE(kNotYetRun) to short-circuit if handler never ran; replace T-06 absolute mask assertions with relative before/after comparisons - AbstractDynamicClassTest.java: split compound Label statements to separate lines for Spotless/google-java-format compliance Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…bodies

jbachorik · 2026-05-15T14:37:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66451207c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Replaces the SpinLock-guarded Dictionary instances (_class_map, _string_label_map, _context_value_map) with a new TripleBufferedDictionary that rotates three Dictionary buffers (active / dump / scratch) under a generic TripleBufferRotator<T> template. Writes go to the active buffer lock-free; the dump thread reads standby() after rotate()/rotatePersistent() drains in-flight readers via RefCountGuard. The previous bounded shared-lock primitives in spinLock.h and the related classMap*Guard() factory methods are removed, and RefCountGuard is generalised (extracted to refCountGuard.h) to operate on void* so it can protect dictionaries as well as call-trace tables.

Changes:

New TripleBufferRotator<T> + TripleBufferedDictionary (with rotate, rotatePersistent, clearStandby, clearAll) and a new Dictionary::mergeFrom used by rotatePersistent.
Generalised RefCountGuard to void* and extracted it from callTraceStorage.h into refCountGuard.h; removed tryLockSharedBounded / BoundedOptionalSharedLockGuard and the _class_map_lock member.
Wired Profiler::dump/stop/start to rotate / clearStandby / clearAll, switched flightRecorder.cpp and hotspotSupport.cpp to read standby() / call bounded_lookup() directly without locking, replaced old gtest suites with a new dictionary_ut.cpp, added a Java DictionaryRotationTest, and disabled ContendedCallTraceStorageTest on musl/aarch64.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
ddprof-lib/src/main/cpp/tripleBuffer.h	New generic 3-buffer rotator with atomic CAS rotate.
ddprof-lib/src/main/cpp/refCountGuard.h	New header extracting `RefCountGuard`/`RefCountSlot` and generalising `active_ptr` to `void*`.
ddprof-lib/src/main/cpp/dictionary.h	Adds `TripleBufferedDictionary`, `Dictionary::mergeFrom`, `counterId()`, `size()` accessors.
ddprof-lib/src/main/cpp/dictionary.cpp	Implements `mergeFrom` (recursive re-insert via `lookup`).
ddprof-lib/src/main/cpp/spinLock.h	Removes `tryLockSharedBounded` and `BoundedOptionalSharedLockGuard`.
ddprof-lib/src/main/cpp/profiler.h	Replaces `Dictionary` members with `TripleBufferedDictionary`; drops `_class_map_lock` + guard factories.
ddprof-lib/src/main/cpp/profiler.cpp	Switches `start`/`stop`/`dump`/`lookupClass` to triple-buffer ops; removes shared-lock dance.
ddprof-lib/src/main/cpp/flightRecorder.cpp	`writeCpool`/`writeClasses` now read `standby()` snapshot without lock.
ddprof-lib/src/main/cpp/hotspot/hotspotSupport.cpp	Removes `classMapTrySharedGuard`; uses `bounded_lookup` directly in vtable-stub path.
ddprof-lib/src/main/cpp/callTraceStorage.h/.cpp	Removes the inline `RefCountGuard` definitions and updates the impl to `void*` resource.
ddprof-lib/src/test/cpp/dictionary_ut.cpp	New gtest covering rotate / clearStandby / merge / counter id / concurrent writes.
ddprof-lib/src/test/cpp/dictionary_concurrent_ut.cpp	Removed (covered the old shared-lock contract).
ddprof-lib/src/test/cpp/spinlock_bounded_ut.cpp	Removed alongside the deleted bounded shared-lock primitive.
ddprof-test/.../DictionaryRotationTest.java	New Java test asserting pre/post-dump separation and counter recalibration.
ddprof-test/.../BoundMethodHandleMetadataSizeTest.java	Drops the (now unused) counter-size assertion.
ddprof-test/.../ContendedCallTraceStorageTest.java	Skips on musl/aarch64 due to a separately tracked native bug.
AGENTS.md	Adds musl/aarch64/JDK11 frame-corruption rule for `start_routine_wrapper_spec`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- AGENTS.md: remove musl/aarch64/JDK11 start_routine_wrapper_spec section - callTraceStorage.cpp: revert active_ptr/standby_ptr → active_table/standby_table - flightRecorder.cpp: add standby() explanation comment in writeClasses - javaApi.cpp: clarify 0-sentinel for StringDictionary::bounded_lookup - profiler.cpp: fix lockAll() comment (it blocks calltrace paths, not dict access) - profiler.cpp: add lookupClass thread-safety explanation Co-Authored-By: muse <muse@noreply>

jbachorik · 2026-05-22T15:13:28Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-05-22T15:24:21Z

@copilot resolve the merge conflicts in this pull request

Resolved. I merged origin/main into this branch and fixed the conflict in ddprof-lib/src/main/cpp/flightRecorder.cpp while preserving the dump-path dictionary lookup behavior. Commits: c44aef93 (merge conflict resolution) and dc827521 (follow-up guard for normalized class-name length).

jbachorik · 2026-05-23T15:29:00Z

@codex review

Copilot

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated 3 comments.

When clang++ is the compiler, -fsanitize=address links libclang_rt.asan-x86_64.so while the explicit -lasan links GCC's libasan.so.X from the gcc fallback path. Both end up in the binary's NEEDED entries, causing "incompatible ASan runtimes" at startup. -fsanitize=address/-fsanitize=undefined handle runtime linking correctly for both GCC and clang without the explicit flags. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

locateLibasan now returns libclang_rt.asan-<arch>.so when the compiler is clang, falling back to GCC's libasan only for GCC builds. configureAsan derives the -l flag from the located library filename: - clang: -lclang_rt.asan-<arch> satisfies -z defs for both __asan_* and __ubsan_* (clang's runtime includes both) and matches the runtime that -fsanitize=address links into executables — one runtime, no conflict. - gcc: -lasan -lubsan as before. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

clang -fsanitize=address on an executable statically embeds the full ASan runtime via --whole-archive libclang_rt.asan*.a. Adding an explicit -lclang_rt.asan / -lasan on top creates a second dynamic NEEDED entry, causing two __asan_init calls and 'incompatible ASan runtimes' at startup. Shared library builds legitimately need the explicit -l to satisfy -z defs. Executables do not — clang handles the runtime automatically.

Copilot

Pull request overview

Copilot reviewed 31 out of 32 changed files in this pull request and generated 3 comments.

StringDictionaryBuffer now maintains DICTIONARY_PAGES and DICTIONARY_BYTES counters alongside the existing DICTIONARY_KEYS/KEYS_BYTES metrics: - initCounters(offset): called by StringDictionary ctor for each buffer; counts the root SBTable that was already allocated at construction time. - insert_with_id: increments on CAS-winning overflow SBTable allocation. - clear(): decrements by the number of overflow nodes freed (root stays). This restores the memory-footprint observability that Dictionary provided via Counters::increment(DICTIONARY_PAGES/BYTES) without changing StringDictionary's correctness or signal-safety properties.

Copilot

Pull request overview

Copilot reviewed 31 out of 32 changed files in this pull request and generated 3 comments.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0995390da6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…clean

…d files

jbachorik added the AI label May 12, 2026

jbachorik mentioned this pull request May 12, 2026

fix(profiler): fix SIGSEGV in Dictionary::clear under concurrent lookup #522

Closed

7 tasks

jbachorik mentioned this pull request May 12, 2026

fix(profiler): TripleBufferedDictionary — fix vtable-stub class lookup and counter tracking #525

Closed

3 tasks

jbachorik force-pushed the muse/crash-sigsegv-in-std-rb-tree-increment-clean branch 2 times, most recently from 2f23bab to 132b472 Compare May 13, 2026 07:42

jbachorik changed the title ~~fix(profiler): lock-free class/endpoint/context maps via DoubleBufferedDictionary~~ fix(profiler): lock-free class/endpoint/context maps via TripleBufferedDictionary May 13, 2026

This was referenced May 13, 2026

fix(profiler): pre-register vtable receiver classes via JVMTI #527

Open

fix(profiler): TripleBufferedDictionary — atomic rotate, counter tracking, stop() cleanup #528

Closed

jbachorik and others added 2 commits May 13, 2026 17:38

jbachorik mentioned this pull request May 13, 2026

fix(profiler): line-number-table UAF, musl/aarch64 wrapper canary, and SIGVTALRM teardown race #510

Merged

2 tasks

jbachorik force-pushed the muse/crash-sigsegv-in-std-rb-tree-increment-clean branch from 7844134 to b90761e Compare May 13, 2026 16:15

jbachorik changed the base branch from main to muse/sigsegv-in-recording May 13, 2026 16:15

jbachorik force-pushed the muse/crash-sigsegv-in-std-rb-tree-increment-clean branch from b90761e to 76d919d Compare May 13, 2026 16:52

jbachorik and others added 2 commits May 14, 2026 13:13

jbachorik force-pushed the muse/crash-sigsegv-in-std-rb-tree-increment-clean branch from 76d919d to 2105b61 Compare May 14, 2026 17:16

jbachorik and others added 3 commits May 15, 2026 12:01

fix: remove double blank line in libraryPatcher_linux.cpp

3b54384

Agent-Logs-Url: https://github.com/DataDog/java-profiler/sessions/127448f3-9624-49bf-92f2-850b4f413a92 Co-authored-by: jbachorik <738413+jbachorik@users.noreply.github.com>

jbachorik force-pushed the muse/crash-sigsegv-in-std-rb-tree-increment-clean branch from 30a5959 to 6645120 Compare May 15, 2026 13:26

jbachorik and others added 2 commits May 15, 2026 15:35

fix(test): replace ASSERT_NE with ADD_FAILURE+return in void* thread …

53e3e46

…bodies

jbachorik requested a review from Copilot May 15, 2026 14:37

Copilot started reviewing on behalf of jbachorik May 15, 2026 14:38 View session

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

Comment thread ddprof-lib/src/main/cpp/profiler.cpp Outdated

Comment thread ddprof-lib/src/main/cpp/dictionary.h Outdated

Comment thread ddprof-lib/src/main/cpp/dictionary.h Outdated

Copilot AI reviewed May 15, 2026

View reviewed changes

jbachorik commented May 22, 2026

View reviewed changes

Copilot started work on behalf of jbachorik May 22, 2026 15:13 View session

Copilot AI added 2 commits May 22, 2026 15:19

Merge origin/main into muse/crash-sigsegv-in-std-rb-tree-increment-clean

c44aef9

fix: guard normalized class name length in dump lookup

dc82752

Copilot finished work on behalf of jbachorik May 22, 2026 15:24

jbachorik requested a review from Copilot May 23, 2026 15:28

Copilot started reviewing on behalf of jbachorik May 23, 2026 15:29 View session

Copilot AI reviewed May 23, 2026

View reviewed changes

Comment thread ddprof-lib/src/main/cpp/stringDictionary.h

Comment thread ddprof-lib/src/main/cpp/stringDictionary.h

Comment thread ddprof-lib/src/main/cpp/profiler.h

jbachorik and others added 5 commits May 23, 2026 18:31

fix(build): exhaustive when for Architecture in locateLibasan

f9cf80f

fix(build): add rpath for clang ASan runtime to gtest/so binaries

01e3d25

jbachorik requested a review from Copilot May 23, 2026 21:29

Copilot started reviewing on behalf of jbachorik May 23, 2026 21:29 View session

Copilot AI reviewed May 23, 2026

View reviewed changes

Comment thread ddprof-lib/src/main/cpp/profiler.h

Comment thread ddprof-lib/src/main/cpp/stringDictionary.h Outdated

Comment thread ddprof-lib/src/main/cpp/stringDictionary.h

jbachorik added 2 commits May 23, 2026 23:44

docs: clarify rotate() comment — JNI callers can insert during rotate

2a8c230

jbachorik requested a review from Copilot May 23, 2026 22:46

Copilot started reviewing on behalf of jbachorik May 23, 2026 22:46 View session

Copilot AI reviewed May 23, 2026

View reviewed changes

Comment thread ddprof-lib/src/main/cpp/stringDictionary.h

Comment thread ddprof-lib/src/main/cpp/stringDictionary.h

Comment thread ddprof-lib/src/main/cpp/stringDictionary.h

jbachorik marked this pull request as ready for review May 24, 2026 05:53

jbachorik requested a review from a team as a code owner May 24, 2026 05:53

chatgpt-codex-connector Bot reviewed May 24, 2026

View reviewed changes

Comment thread ddprof-lib/src/main/cpp/tripleBuffer.h Outdated

jbachorik added 2 commits May 24, 2026 08:57

Merge branch 'main' into muse/crash-sigsegv-in-std-rb-tree-increment-…

070e87c

…clean

fix: update copyright year to 2026 in tripleBuffer.h and refCountGuar…

268b686

…d files

Conversation

jbachorik commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Test Results

Status Overview

Uh oh!

jbachorik commented May 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbachorik commented May 22, 2026

Uh oh!

Copilot AI commented May 22, 2026

Uh oh!

jbachorik commented May 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

jbachorik commented May 12, 2026 •

edited

Loading

dd-octo-sts Bot commented May 12, 2026 •

edited

Loading