feat(sidecar): wire telemetry_extended_heartbeat_interval through SessionConfig#1882
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intoApr 17, 2026
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
==========================================
- Coverage 71.71% 71.60% -0.11%
==========================================
Files 431 431
Lines 69140 69147 +7
==========================================
- Hits 49582 49516 -66
- Misses 19558 19631 +73
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 67a8a7b | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
…sionConfig Add telemetry_extended_heartbeat_interval to the sidecar's SessionConfig and FFI so that callers (e.g. PHP) can configure the extended heartbeat interval. The telemetry worker already supports this field in its Config but the sidecar was not passing it through. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The ExtendedHeartbeat lifecycle action was wrapping the payload in Payload::AppStarted instead of Payload::AppExtendedHeartbeat, causing it to serialize as "app-started" instead of "app-extended-heartbeat". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add telemetry_extended_heartbeat_interval_millis argument (86400000ms = 24h default) to both ddog_sidecar_session_set_config calls in the sidecar FFI test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
khanayan123
force-pushed
the
ayan.khan/wire-extended-heartbeat-sidecar
branch
from
1a43b5c to
a03953e
Compare
hoolioh
approved these changes
Apr 16, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
DDCI pipeline didn't start (sourcing_failed)... Please retry. DDCI Change Request: |
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: waiting
and removed
mergequeue-status: error
mergequeue-status: waiting
labels
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
ayan.khan/wire-extended-heartbeat-sidecar
branch
khanayan123
added a commit
to DataDog/dd-trace-php
that referenced
this pull request
Apr 21, 2026
PR DataDog/libdatadog#1882 (wire extended heartbeat interval through the sidecar) has merged to main, so repoint the submodule from the feature branch to c03245d4e on main.
2 tasks
This was referenced May 15, 2026
iunanua
added a commit
that referenced
this pull request
May 15, 2026
# Release proposal for libdd-telemetry and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-capabilities **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-v2.0.0` ### Commits - feat(capablities)!: sleep & spawn capabilities (#1873) ## libdd-common **Next version:** `4.1.0` **Semver bump:** `minor` **Tag:** `libdd-common-v4.1.0` ### Commits - refactor(sampling): move the sampling logic from dd-trace-rs [APMSP-2946] (#1927) - feat!: added regex-lite feature (#1939) - fix(libdd-common): crashes caused by `getenv` while retrieving AAS env vars (#1930) ## libdd-capabilities-impl **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-impl-v2.0.0` ### Commits - feat(capablities)!: sleep & spawn capabilities (#1873) ## libdd-shared-runtime **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-shared-runtime-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. ## libdd-telemetry **Next version:** `5.0.0` **Semver bump:** `major` **Tag:** `libdd-telemetry-v5.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^3.0.2 → ^4.0.0 ### Commits - fix(libdd-telemetry): restore previous Cargo.toml version (#1993) - feat(capablities)!: sleep & spawn capabilities (#1873) - fix(telemetry): avoid trigger loop in telemetry worker (#1950) - feat(telemetry)!: include dependencies and integrations in app-extended-heartbeat (#1962) - fix(crypto): gate libdd-common TLS features in remaining internal crates + add CI guard (#1943) - fix(telemetry): schedule ExtendedHeartbeat on worker start (#1910) - fix(telemetry): skip sending empty payloads (#1894) - feat(sidecar): wire telemetry_extended_heartbeat_interval through SessionConfig (#1882) - chore(telemetry): add session id support (#1817) - ci(libdd-shared-runtime): downgrade version so publish workflow succeeds (#1870) - feat(runtime)!: add shared runtime (#1602) - perf(sidecar)!: Batch ack sending & consumption (#1835) - fix(telemetry): wire up DD_TELEMETRY_EXTENDED_HEARTBEAT_INTERVAL to scheduler (#1824) - feat(capabilities)!: trait architecture http (#1555) - chore(telemetry): use weaker mem ordering for SEQ_ID (#1749) [APMSP-2946]: https://datadoghq.atlassian.net/browse/APMSP-2946?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: iunanua <18325288+iunanua@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
telemetry_extended_heartbeat_intervalto the sidecar'sSessionConfigand FFIlayer so that callers (e.g. PHP tracer) can configure the extended heartbeat interval.
The telemetry worker already supports this field in its
Configstruct, but the sidecarwas not passing it through from
SessionConfig->modify_telemetry_config. This meantsidecar consumers could not control the cadence of
app-extended-heartbeatevents.Changes:
datadog-sidecar/src/service/mod.rs: addtelemetry_extended_heartbeat_interval: DurationtoSessionConfigdatadog-sidecar/src/service/sidecar_server.rs: setcfg.telemetry_extended_heartbeat_intervalinmodify_telemetry_configdatadog-sidecar-ffi/src/lib.rs: addtelemetry_extended_heartbeat_interval_millis: u64param toddog_sidecar_session_set_configCompanion dd-trace-php PR: DataDog/dd-trace-php#3800