Skip to content

feat(shared_runtime)!: allow worker to be stopped after fork#1893

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
vianney/cleanup_after_fork
Apr 20, 2026
Merged

feat(shared_runtime)!: allow worker to be stopped after fork#1893
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
vianney/cleanup_after_fork

Conversation

@VianneyRuhlmann
Copy link
Copy Markdown
Contributor

@VianneyRuhlmann VianneyRuhlmann commented Apr 20, 2026

What does this PR do?

Allow a worker to not be restarted after a fork in the child, the worker is instead dropped without calling shutdown.

Motivation

Currently the trace exporter is recreated on forks in dd-trace-py, this is down without calling shutdown to avoid flushing data twice. To avoid restarting workers and keeping them around, the trace exporter workers are not restarted after the fork.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@github-actions
Copy link
Copy Markdown
Contributor

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/vianney/cleanup_after_fork

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 2 2 No change (0%)
Total 2 2 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
libdd-data-pipeline/src/telemetry/mod.rs 1 1 No change (0%)
libdd-trace-stats/src/stats_exporter.rs 1 1 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 21 21 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 56 56 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 4 4 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-stats 1 1 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 197 197 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@VianneyRuhlmann VianneyRuhlmann changed the title feat(shared_runtime): allow worker to be stopped after fork feat(shared_runtime)!: allow worker to be stopped after fork Apr 20, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.62%. Comparing base (0b00c9c) to head (95ced97).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
+ Coverage   71.60%   71.62%   +0.02%     
==========================================
  Files         431      431              
  Lines       69156    69178      +22     
==========================================
+ Hits        49517    49552      +35     
+ Misses      19639    19626      -13     
Components Coverage Δ
libdd-crashtracker 66.03% <ø> (+0.01%) ⬆️
libdd-crashtracker-ffi 34.47% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 85.45% <66.66%> (-0.03%) ⬇️
libdd-data-pipeline-ffi 71.94% <ø> (ø)
libdd-common 79.16% <ø> (ø)
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 68.07% <ø> (ø)
libdd-telemetry-ffi 19.37% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 76.31% <ø> (ø)
libdd-profiling 81.60% <ø> (ø)
libdd-profiling-ffi 64.36% <ø> (ø)
datadog-sidecar 29.43% <ø> (ø)
datdog-sidecar-ffi 8.04% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.26% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.24% <ø> (ø)
datadog-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented Apr 20, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 87.18%
Overall Coverage: 71.63% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 95ced97 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 20, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.63 MB 7.63 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 83.31 MB 83.31 MB +0% (+112 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.10 MB 10.10 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.40 MB 99.40 MB -0% (-224 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.18 MB 25.18 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.90 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.34 MB 184.36 MB +0% (+16.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.46 MB 917.52 MB +0% (+64.18 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 7.89 MB 7.89 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.90 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.66 MB 23.66 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 46.18 MB 46.18 MB +0% (+82 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.65 MB 21.65 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.14 KB 81.14 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.44 MB 188.44 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 902.76 MB 902.83 MB +0% (+64.84 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.13 MB 6.13 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.14 KB 81.14 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 25.35 MB 25.35 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 43.66 MB 43.66 MB +0% (+14 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.42 MB 74.42 MB +0% (+112 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.52 MB 8.52 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.77 MB 91.77 MB +0% (+120 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.20 MB 10.20 MB 0% (0 B) 👌

@VianneyRuhlmann VianneyRuhlmann marked this pull request as ready for review April 20, 2026 13:43
@VianneyRuhlmann VianneyRuhlmann requested review from a team as code owners April 20, 2026 13:43
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 5b798ae into main Apr 20, 2026
94 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the vianney/cleanup_after_fork branch April 20, 2026 14:22
iunanua added a commit that referenced this pull request May 18, 2026
# Release proposal for libdd-data-pipeline and its dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-dogstatsd-client
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-dogstatsd-client-v3.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^3.0.2 → ^4.1.0

### Commits

- fix(crypto): gate libdd-common TLS features in remaining internal
crates + add CI guard (#1943)

## libdd-trace-obfuscation
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-obfuscation-v3.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^3.0.2 → ^4.1.0
- `libdd-trace-utils`: ^3.0.1 → ^4.0.0

### Commits

- feat!: integrate obfuscation to the stats exporter [APMSP-2764]
(#1819)
- feat!: added regex-lite feature (#1939)
- chore: clippy (#1889)
- fix(crypto): gate libdd-common TLS features in obfuscation and
capabilities-impl (#1872)
- feat(obfuscation)!: feature parity on span obfuscation [APMSP-2671]
(#1788)
- feat(obfuscation/sql): feature parity on sql obfuscation [APMSP-2667]
(#1708)

## libdd-trace-stats
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-stats-v3.0.0`

### ⚠️ major bump forced due to:

- `libdd-trace-utils`: ^3.0.1 → ^4.0.0

### Commits

- perf: pre-compute string messagepack encoding (#1948)
- feat!: integrate obfuscation to the stats exporter [APMSP-2764]
(#1819)
- feat(capablities)!: sleep & spawn capabilities (#1873)
- feat: use ip quantization when aggregating peer tags for trace stats
(#1944)
- fix(crypto): gate libdd-common TLS features in remaining internal
crates + add CI guard (#1943)
- feat(shared_runtime)!: allow worker to be stopped after fork (#1893)
- feat(sidecar)!: Add stats computation via SHM (#1821)
- feat(stats): propagate service source from span meta to client stats
payload (#1803)
- fix(stats): align with css spec (#1790)

## libdd-data-pipeline
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-data-pipeline-v4.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^3.0.2 → ^4.1.0
- `libdd-telemetry`: ^4.0.0 → ^5.0.0
- `libdd-trace-utils`: ^3.0.1 → ^4.0.0

### Commits

- fix(libdd-telemetry): restore previous Cargo.toml version (#1993)
- fix(data-pipeline): remove default-features from of trace-obfuscation
(#1981)
- fix(trace_exporter: shared_runtime): unwrap_or being eager is not good
(#1983)
- perf: pre-compute string messagepack encoding (#1948)
- feat!: integrate obfuscation to the stats exporter [APMSP-2764]
(#1819)
- feat(capablities)!: sleep & spawn capabilities (#1873)
- fix(telemetry): avoid trigger loop in telemetry worker (#1950)
- feat(telemetry)!: include dependencies and integrations in
app-extended-heartbeat (#1962)
- perf(trace-serializer): pre-allocate serialization buffer (#1949)
- feat!: added regex-lite feature (#1939)
- fix(crypto): gate libdd-common TLS features in remaining internal
crates + add CI guard (#1943)
- feat(telemetry): add session id support to trace export (#1822)
- fix(path): missing bench path in data-pipeline (#1907)
- feat(data-pipeline): port dd-trace-rs trace buffer implementation
(#1826)
- feat(info_fetcher): add timeout to info fetcher (#1890)
- feat(shared_runtime)!: allow worker to be stopped after fork (#1893)
- feat(sidecar)!: Add stats computation via SHM (#1821)
- ci(libdd-shared-runtime): downgrade version so publish workflow
succeeds (#1870)
- feat(runtime)!: add shared runtime (#1602)
- ci: compilation of libdd-data-pipeline to wasm32 (#1830)
- feat(capabilities)!: trait architecture http (#1555)
- feat(otel): add support for OTLP trace export (#1641)
- fix(stats): align with css spec (#1790)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: iunanua <18325288+iunanua@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants