This repository was archived by the owner on Jun 5, 2025. It is now read-only.
[libyaml] mercurial repos gone; use github.#375
Merged
Conversation
[libyaml] do not force seven_zip extractor [libyaml] switch to tarball
bmikaili
approved these changes
Sep 3, 2020
olivielpeau
reviewed
Sep 3, 2020
Member
There was a problem hiding this comment.
I've done some more digging:
- it looks like the commit pinned on the mercurial repo was added in this PR: #59, previously we were pulling the tip of master. This was merged on
Jun 21, 2016 0.1.6was tagged in 2014, 2 years prior: https://github.com/yaml/libyaml/releases/tag/0.1.6, whereas 0.1.7 was tagged onAug 27, 2016: https://github.com/yaml/libyaml/releases/tag/0.1.7. In particular this fix was included in both0.1.7and (based on dates) in the version we were previously pinning, looks important: yaml/libyaml@686b2d8- we pin 0.1.7 in the windows software def: https://github.com/DataDog/omnibus-software/blob/agent-v5/config/software/libyaml-windows.rb (haven't checked we're actually using it for agent 5 though :) )
(we could go as far as pinning the same version as v6/v7 agents, i.e. 0.2.2 -- see #326 -- since we've upgraded pyyaml in Agent v5 as well; but there seems to be no CVEs since 0.1.7, so not needed IMO, see https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=libyaml)
Anyway, overall I think pinning 0.1.7 is best.
olivielpeau
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.