fix(test): suppress OpenSSL builtin-compressions LSan leak on Node 26#359
Closed
szegedi wants to merge 1 commit into
Closed
fix(test): suppress OpenSSL builtin-compressions LSan leak on Node 26#359szegedi wants to merge 1 commit into
szegedi wants to merge 1 commit into
Conversation
Node 26's OpenSSL populates a global builtin-compressions list during OPENSSL_init_crypto (ossl_load_builtin_compressions) that is never freed at process exit, causing the ASAN job to fail with a 24-byte leak report. This is the same class of benign one-time process-init leak we already suppress via CRYPTO_zalloc, but this path allocates via CRYPTO_malloc and so slips through. Suppress the specific ossl_load_builtin_compressions frame rather than broadening to CRYPTO_malloc, which is OpenSSL's general allocator and could mask genuine leaks in crypto code paths. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Overall package sizeSelf size: 2.19 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | pprof-format | 2.2.2 | 500.53 kB | 500.53 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Author
|
Folded into #360 (cherry-picked as a separate commit there). The wall-profiler UAF fix and this LSan suppression each block the other's CI from going green, so they need to land together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an LSan suppression for the OpenSSL builtin-compressions one-time-init leak that is failing the ASAN job on Node.js 26.
Why
The ASAN (26) job fails with:
Node 26's OpenSSL populates a global builtin-compressions list during
OPENSSL_init_cryptothat is never freed at process exit. This is the same class of benign, one-time process-init leak we already suppress vialeak:CRYPTO_zalloc— but this path allocates viaCRYPTO_mallocand so isn't matched by the existing rule.How
Suppress the specific
ossl_load_builtin_compressionsframe rather than broadening toCRYPTO_malloc.CRYPTO_mallocis OpenSSL's general-purpose allocator used throughout, so suppressing it would risk masking genuine leaks in crypto code paths; theossl_load_builtin_compressionsframe pinpoints exactly this init leak.🤖 Generated with Claude Code